Bug 751072

Summary:	Some condor_* commands with valid parameter '-help' return non zero exit code
Product:	Red Hat Enterprise MRG	Reporter:	Daniel Horák <dahorak>
Component:	condor	Assignee:	Timothy St. Clair <tstclair>
Status:	CLOSED ERRATA	QA Contact:	Martin Kudlej <mkudlej>
Severity:	low	Docs Contact:
Priority:	low
Version:	Development	CC:	ltoscano, matt, mkudlej, tstclair
Target Milestone:	2.1.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	condor-7.6.5-0.9	Doc Type:	Bug Fix
Doc Text:	C: Run condor tools with -help from the command line and check the return code. C: Return code is non-zero when it should be 0 F: Update the tools to return 0 when executing with -help R: Running condor tools with -help from the command line returns 0	Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-06 18:17:48 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	765607, 773434

Description Daniel Horák 2011-11-03 13:06:13 UTC

Description of problem:
Some commands condor_* return with valid parameter '-help' exit code different of zero. 
Acts about e.g. condor_config_val, condor_continue, condor_history, condor_hold, condor_off, condor_on, condor_release, condor_suspend,...

Version-Release number of selected component (if applicable):
condor-7.6.5-0.5

How reproducible:
100%

Steps to Reproduce:
Run mentioned commands with parameter '-help' and control exit code.
# condor_rm -help
# echo $?

  
Actual results:
Commands return with valid parameter -help non zero return code.

Expected results:
Commands should return zero with valid parameter -help.

Comment 4 Timothy St. Clair 2011-12-14 17:40:40 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: Run condor tools with -help from the command line and check the return code.
C: Return code is non-zero when it should be 0
F: Update the tools to return 0 when executing with -help
R: Running condor tools with -help from the command line returns 0

Comment 5 Martin Kudlej 2012-01-04 13:51:52 UTC

There are still commands which returns $? != 0 for '-h' or '-help' parameter:
$  condor_cod -h; echo $?
...
1

$  condor_findhost -h; echo $?
...
1

$ condor_router_history -h; echo $?
...
1

$ condor_ssh_to_job -h; echo $?
...
2

$ condor_submit_dag -help; echo $?
...
1

$ condor_userlog -help; echo $?
...
1

$ condor_wait -help; echo $?
...
1

Tested with condor-7.6.5-0.11.el5/.el6.

Comment 6 Timothy St. Clair 2012-01-04 14:19:17 UTC

Is the afore mentioned list complete?

Comment 7 Martin Kudlej 2012-01-05 09:42:27 UTC

I've got list of binaries in condor package(rpm -ql | grep bin) and run them with -h and -help. I've sorted out those one which returned non zero value to 2 categories. First category contains binaries which have not in man pages or among parameters -h or -help so non-zero return code is OK. And binaries from second category you can see in comment #5. So yes, that is complete list of binaries in condor package which return non-zero value if it is called with -h or -help and they have in man page or among parameters -h or -help.

Comment 10 Martin Kudlej 2012-01-20 09:37:08 UTC

There is new bug 773434 for rest commands. -->VERIFIED

Comment 11 errata-xmlrpc 2012-02-06 18:17:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0100.html