| Summary: | ypinit incorrectly identifies domainname when none is set. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shannon Petry <shannon.petry> | ||||
| Component: | ypserv | Assignee: | Honza Horak <hhorak> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 15 | CC: | hhorak, kklic | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ypserv-2.26-8.fc16 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-12-10 19:39:09 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
|
Description
Shannon Petry
2011-11-04 17:16:59 UTC
[spetry@nyfinhost1 ~]$ git diff ypinit ./ypinit
diff --git a/ypinit b/ypinit
index 3c0dc1c..c76c849 100755
--- a/ypinit
+++ b/ypinit
@@ -149,15 +149,14 @@ then
exit 1
fi
-DOMAIN=`domainname`
-if [ $? -ne 0 ]
-then
- echo "Can't find domainname. Please fix your PATH"
+if [ -x /bin/domainname ] ; then
+ DOMAIN=`domainname`
+else
+ echo "'domainname' command not found. Exiting."
exit 1
fi
-if [ -z "$DOMAIN" ]
-then
+if [ "${DOMAIN}x" = "x" ] || [ "${DOMAIN}" = "(none)" ] ; then
echo "The local host's domain name hasn't been set. Please set it."
exit 1
fi
Created attachment 531826 [details]
Modified ypinit script
diff is included in comments.
It would be relatively easy for me to change the ypinit script to read in /etc/sysconfig/network to determine if NISDOMAIN or YPDOMAIN is set. An option of setting the domain name inside the script could be presented to the user. In addition, I would also be able to add functionality to the ypinit script to update the NISDOMAIN in /etc/sysconfig/network, similar to Sun's original functionality with ypinit where an /etc/defaultdomain is created. This would record the settings for next boot without manual intervention. Please let me know if you want me to proceed with the additions. Hi Shannon,
thanks for the suggested fix. I've already applied the following change into Rawhide and will update it in f16 soon:
-if [ -z "$DOMAIN" ]
+if [ "${DOMAIN}x" = "x" ] || [ "${DOMAIN}" = "(none)" ]
However, I don't think it is really necessary to apply the other one, since I don't see any use case when it should help something. If you do, describe the use case a bit, please.
ypserv-2.26-7.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ypserv-2.26-7.fc16 ypserv-2.24-6.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/ypserv-2.24-6.fc15 ypserv-2.26-8.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/ypserv-2.26-8.fc16 Package ypserv-2.26-8.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ypserv-2.26-8.fc16' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-16503/ypserv-2.26-8.fc16 then log in and leave karma (feedback). ypserv-2.24-6.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. ypserv-2.26-8.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |