Bug 751516

Summary: fedora-release-note launcher contains zero-width space under zh_CN
Product: [Fedora] Fedora Reporter: Tommy He <lovenemesis>
Component: fedora-release-notesAssignee: Pete Travis <me>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 19CC: david, dennis, koala, lonicerae, me, pswo10680, sparks, wb8rcr, zach
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-04 01:03:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot on Fedora 16 RC5 under zh_CN none

Description Tommy He 2011-11-05 04:33:47 UTC
Created attachment 531873 [details]
Screenshot on Fedora 16 RC5 under zh_CN

Description of problem:

The name displayed in application launcher contains unicode for zh_CN.

Version-Release number of selected component (if applicable):

fedora-release-notes-16.1.0-1.fc16.noarch

How reproducible:

100%

Steps to Reproduce:
1. Update to 16.1.0-1
2. Change language to Chinese(China)
3. Observe the name of release note in application launcer (Gnome Shell App tab, KDE4 Launcher)
  
Actual results:

Fedora 16 发&#x200B;行&#x200B;注&#x200B;记&#x200B;

Expected results:

Fedora 16 发行注记

Additional info:

Seems the info in desktop files are wrong:

In /usr/share/applications/fedora-release-notes.desktop :
Name[zh_CN]=发&#x200B;行&#x200B;注&#x200B;记&#x200B;
Comment[zh_CN]=Fedora 16 发&#x200B;行&#x200B;注&#x200B;记&#x200B;

The same wrong text appears in /usr/share/applications/fedora-release-notesX.desktop and /usr/share/applications/kde4/fedora-release-notes.desktop

Comment 1 Tommy He 2012-04-18 17:52:49 UTC
It's also reproducible on Fedora 17 Beta.

Comment 2 Hann-Huei Chiou 2012-06-19 21:04:36 UTC
and in Fedora 17 release (fedora-release-notes-17.1.0-1.fc17.noarch)
both zh_CN and zh_TW have this issue

Comment 3 Tommy He 2012-12-10 00:47:01 UTC
Same issue happens in Fedora 18 Beta on fedora-release-notes-17.95.0-0.fc18

Comment 4 Tommy He 2013-05-31 03:24:37 UTC
It happens in Fedora 19 as well.

I'm start questioning if there's anyone maintaining this package.

Comment 5 Pete Travis 2013-05-31 04:11:38 UTC
Hi Tommy,

I'm maintaining this package now, and with your help should be able to take care of this.

First, the string for the .desktop file is pulled from the translation of the document itself. Can you verify that "Fedora Release Notes" is translated accurately and appears correctly in your browser?

The .desktop file is located at /usr/share/applications/fedora-release-notes.desktop . Are the characters in that file correct if viewed from an editor or terminal?

Finally, can you verify you have the latest version of the package?

Thanks,
--Pete

Comment 6 Pete Travis 2013-05-31 06:42:51 UTC
Sorry, I should be more clear: The latest version of the F19 package probably doesn't have zh_CN content. The latest version of the F18 package does. If the F18 package is correct, then the F19 version will also be correct when the translation is complete.

Comment 7 Tommy He 2013-06-04 02:19:43 UTC
Very glad to hear some feedback.

> First, the string for the .desktop file is pulled from the translation of
> the document itself. Can you verify that "Fedora Release Notes" is
> translated accurately and appears correctly in your browser?

Yes, the Release Notes itself is translated and displayed correctly in default Firefox browser. I'm also one of the translators.

> The .desktop file is located at
> /usr/share/applications/fedora-release-notes.desktop . Are the characters in
> that file correct if viewed from an editor or terminal?

No, it still contains the zero-width space in .desktop file, as my original comment shows.

> Sorry, I should be more clear: The latest version of the F19 package
> probably doesn't have zh_CN content. The latest version of the F18 package
> does. If the F18 package is correct, then the F19 version will also be
> correct when the translation is complete.

No, it has been wrong since Fedora 16. It's not right in F18 package, either.

Correct me if I'm wrong. From your saying the /usr/share/applications/fedora-release-notes.desktop pulls the translation from https://fedora.transifex.com/projects/p/fedora-release-notes/ . It doesn't look likely to be the case. For each release there are roughly 5 - 8 fully translated release notes, including zh_CN and zh_TW. But that fedora-release-notes.desktop only contains less than a handful translations. It doesn't seem to be touched for a long time.

Comment 8 Pete Travis 2013-06-08 05:28:19 UTC
The way the RPM is built was changed shortly after the F18 release. Here's the spec: http://pkgs.fedoraproject.org/cgit/fedora-release-notes.git/plain/fedora-release-notes.spec?h=f19

The section: 
TRANSCOMMENT=$(grep -A1 'msgid "%{summary} for Fedora %{version}"'  ${LANGDIR}/Article_Info.po |tail -1|sed -r 's/.*"(.*)".*$/\1/')
	  desktop-file-edit --set-key="Name[${REALLANG}]" "--set-value=${TRANSNAME}" build/%{name}.desktop
       	  desktop-file-edit --set-key="Comment[${REALLANG}]" --set-value="${TRANSCOMMENT}" build/%{name}.desktop

is pulling the string directly from your POs:

#. Tag: subtitle
#, no-c-format
msgid "Release Notes for Fedora 18"
msgstr "Fedora 18 发行注记"

I'm interested to see how it displays when the F19 POs are ready.

Comment 9 Tommy He 2013-06-09 00:34:08 UTC
Translation work for Fedora 19 Article_Info.po is done.

So may I assume that once fedora-release-note.rpm is updated, this issue will be resolved?

Comment 10 Pete Travis 2013-06-28 14:50:49 UTC
Hi, just checking in. The fedora-release-note-19.rpm has been updated, with zh_CN translation. Can you verify if this issue persists?

Comment 11 Tommy He 2013-08-04 01:03:21 UTC
(In reply to Pete Travis from comment #10)
> Hi, just checking in. The fedora-release-note-19.rpm has been updated, with
> zh_CN translation. Can you verify if this issue persists?

Sorry for late response. I can confirm it's fixed on fedora-release-notes-19-0.13.noarch.