Bug 751568
| Summary: | Review Request: libgxps - library for handling and rendering XPS documents | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Hughes <tom> |
| Component: | Package Review | Assignee: | Gwyn Ciesla <gwync> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | agrover, gwync, notting, package-review |
| Target Milestone: | --- | Flags: | gwync:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libgxps-0.2.0-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-11 21:52:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom Hughes
2011-11-05 18:04:02 UTC
one small nit on the subpackage requires: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Requires: %{name}%{?_isa} = %{version}-%{release} otherwise looks very good to me! I've updated the spec file with that change. New spec file and SRPM are here: http://download.compton.nu/rpms/libgxps.spec http://download.compton.nu/rpms/libgxps-0.1.0-2.fc15.src.rpm I've also raised #751582 to suggest that the template for libraries in rpmdevtool be changed to reflect this. Good: - rpmlint checks return: libgxps.x86_64: W: spelling-error Summary(en_US) GObject -> G Object, Object The value of this tag appears to be misspelled. Please double-check. Ignore. libgxps.x86_64: E: incorrect-fsf-address /usr/share/doc/libgxps-0.1.0/COPYING The Free Software Foundation address in this file seems to be outdated or misspelled. Ask upstream to update the address, or if this is a license file, possibly the entire file with a new copy available from the FSF. Fix at your convenience, not a blocker. 3 packages and 0 specfiles checked; 1 errors, 1 warnings. - package meets naming guidelines - package meets packaging guidelines - license ( LGPLv2+ ) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file EXTRA STUFF FOR PACKAGES WITH DEVEL ========================== - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Otherwise it's perfect. Given the practice review, I think I'd like to see one more practice review, and if that's good then I'll be willing to sponsor you and approve this. I did actually do another review today - it's this one: https://bugzilla.redhat.com/show_bug.cgi?id=756321 I've reported the FSF address issue upstream at https://bugzilla.gnome.org/show_bug.cgi?id=664644 but it seems that FSF don't publish an updated LGPLv2 so they may not want to change it. Looks great, do you have a FAS account yet? Yes - tomh is my FAS account. Added, sponsored, package APPROVED. Welcome, use your powers for good, etc. Please feel free to ask any questions if you run into trouble or are curious about anything. New Package SCM Request ======================= Package Name: libgxps Short Description: library for handling and rendering XPS documents Owners: tomh Branches: f15 f16 InitialCC: Git done (by process-git-requests). libgxps-0.1.0-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libgxps-0.1.0-2.fc16 libgxps-0.1.0-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libgxps-0.1.0-2.fc15 libgxps-0.1.0-2.fc15 has been pushed to the Fedora 15 testing repository. libgxps-0.2.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/libgxps-0.2.0-1.fc16 libgxps-0.2.0-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/libgxps-0.2.0-1.fc15 libgxps-0.2.0-1.fc16 has been pushed to the Fedora 16 stable repository. libgxps-0.2.0-1.fc15 has been pushed to the Fedora 15 stable repository. |