Bug 752089

Summary:	Review Request: rubygem-wirble - Handful of common Irb features, made easy
Product:	[Fedora] Fedora	Reporter:	Darryl L. Pierce <dpierce>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, tross
Target Milestone:	---	Flags:	mtasaka: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-22 14:26:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Darryl L. Pierce 2011-11-08 14:31:26 UTC

Spec URL: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec
SRPM URL: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-1.fc15.src.rpm
Description: Handful of common Irb features, made easy.

Comment 1 Mamoru TASAKA 2011-12-21 15:04:40 UTC

Taking.

Comment 2 Mamoru TASAKA 2011-12-21 16:01:21 UTC

 License
  - The "main" license should be MIT as COPYING says so.
    setup.rb is written by Minero Aoki and it seems
    this script is used not only by this software
    (by searching with google), so this script is not directly
    this software's product.

    So for now I think the license tag should be "MIT" or
    "MIT and LGPLv2" (not LGPLv2+, setup.rb is version 2.1
    specific).

* Documents
  - The following files should be moved to -doc
---------------------------------------------------
%{geminstdir}/Rakefile
%{geminstdir}/setup.rb
%{geminstdir}/wirble.gemspec
---------------------------------------------------
  - The following files can be marked as %doc.
---------------------------------------------------
%{geminstdir}/_irbrc
---------------------------------------------------

* Macros
  - %ruby_sitelib is just defined but not used anywhere.

Other things seems okay.

Comment 3 Darryl L. Pierce 2011-12-21 16:24:03 UTC

(In reply to comment #2)
>  License
>   - The "main" license should be MIT as COPYING says so.
>     setup.rb is written by Minero Aoki and it seems
>     this script is used not only by this software
>     (by searching with google), so this script is not directly
>     this software's product.
> 
>     So for now I think the license tag should be "MIT" or
>     "MIT and LGPLv2" (not LGPLv2+, setup.rb is version 2.1
>     specific).

Fixed.

> * Documents
>   - The following files should be moved to -doc
> ---------------------------------------------------
> %{geminstdir}/Rakefile
> %{geminstdir}/setup.rb
> %{geminstdir}/wirble.gemspec

Done.

> ---------------------------------------------------
>   - The following files can be marked as %doc.
> ---------------------------------------------------
> %{geminstdir}/_irbrc

Done.

> ---------------------------------------------------
> 
> * Macros
>   - %ruby_sitelib is just defined but not used anywhere.

Removed.
 
> Other things seems okay.

Updated Spec: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble.spec
Updated SRPM: http://mcpierce.fedorapeople.org/rpms/rubygem-wirble-0.1.3-2.fc16.src.rpm

Comment 4 Mamoru TASAKA 2011-12-22 04:37:48 UTC

Approving.

-----------------------------------------------------------
    This package (rubygem-wirble) is APPROVED by mtasaka
-----------------------------------------------------------

Comment 5 Darryl L. Pierce 2011-12-22 13:08:34 UTC

Thank you!

New Package SCM Request
=======================
Package Name:      rubygem-wirble
Short Description: Handful of common IRB features, made easy
Owners:            mcpierce
Branches:          f15 f16 el6
InitialCC:

Comment 6 Gwyn Ciesla 2011-12-22 13:55:47 UTC

Git done (by process-git-requests).

Comment 7 Darryl L. Pierce 2011-12-22 14:26:37 UTC

Thank you, Jon and Mamoru!