Bug 752239
Summary: | at runtime, coregui.war should default to the "en" locale, not the "default" locale | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | Ian Springer <ian.springer> |
Component: | Core UI | Assignee: | Charles Crouch <ccrouch> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 4.2 | CC: | ccrouch, hbrock, hrupp |
Target Milestone: | --- | ||
Target Release: | RHQ 4.3.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | 4.3 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-08-31 10:12:04 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 745494 |
Description
Ian Springer
2011-11-08 22:13:35 UTC
[master 06ec3b2]: 1) at runtime, default to the "en" locale, not the "default" locale 2) use "en", rather than "default", as the fallback locale (i.e. the locale to fallback to if the user specifies an unsupported locale in the query string QE, test 1) and 2) as follows: 1) just go to the GUI and make sure everything still works and that all messages are English 2) go to http://localhost:7080/coregui/?locale=xy and verify that the GUI comes up as usual and all messages are in English verified jon 3 branch 11/10/2011 This fix only went in to master, so master should be verified, rather than the jon3 branch. what was broken then? it works just fine in jon 3.0 branch? apparently without the fix.... reducing the priority as it is not related to jon 3 editing the target release to remove jon 3 from the target release (per comment #4) Nothing was broken per se. As described by the GWT docs link I included in this bug's description, if you use the "default" locale (what we were previously doing), it is not the same as using the "en" locale - numbers, dates, and currencies will not be formatted properly for English, and message pluralization will not work. I know we had issues with pluralization not working when we first began internationalizing the GUI - this was probably why. I don't know if we currently had any issues due to using the "default" locale, but rather than wait for issues to arise, I decided to preemptively switch to the "en" locale, particularly since the GWT docs specifically recommend this. QA for this is essentially making sure there are no regressions from the change (I don't expect any). verified master 11/11/2011 Bulk close of old bugs in VERIFIED state. |