Bug 752254
Summary: | libvirt fails to initialize nwfilter when /tmp is mounted with noexec option | |||
---|---|---|---|---|
Product: | [Community] Virtualization Tools | Reporter: | Bartlomiej Leszak <bartekl> | |
Component: | libvirt | Assignee: | Eric Blake <eblake> | |
Status: | CLOSED NEXTRELEASE | QA Contact: | ||
Severity: | medium | Docs Contact: | ||
Priority: | unspecified | |||
Version: | unspecified | CC: | crobinso, eblake, xen-maint | |
Target Milestone: | --- | |||
Target Release: | --- | |||
Hardware: | All | |||
OS: | Linux | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 752255 (view as bug list) | Environment: | ||
Last Closed: | 2011-11-10 00:48:12 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 752255 |
Description
Bartlomiej Leszak
2011-11-08 23:25:10 UTC
(In reply to comment #0) > Description of problem: > > Additional info: > Since ebiptablesExecCLI() function's only purpose is to run script generated > for checking iptables/ip6tables/ebtables capabilities it should be easy to fix > this function. It should invoke this script with `/bin/sh /tmp/tmp_script_path' > instead of calling it directly. Agree - and this should be a fairly easy patch to get approved. Libvirt 0.9.8 (or whatever it is numbered) will include this. commit 3b7122c0b24b59ade17dbf72c22dbdfdad89bb08 Author: Eric Blake <eblake> Date: Wed Nov 9 10:29:57 2011 -0700 nwfilter: simplify execution of ebiptables scripts It's not worth even worrying about a temporary file, unless we ever expect the script to exceed maximum command-line argument length limits. * src/nwfilter/nwfilter_ebiptables_driver.c (ebiptablesExecCLI): Run the commands as an argument to /bin/sh, rather than worrying about a temporary file. (ebiptablesWriteToTempFile): Delete unused function. |