| Summary: | ProgressTracker needs update to handle a resuming partial download | ||
|---|---|---|---|
| Product: | [Retired] Pulp | Reporter: | John Matthews <jmatthew> |
| Component: | user-experience | Assignee: | John Matthews <jmatthew> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Preethi Thomas <pthomas> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 1.0.0 | CC: | skarmark |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
John Matthews
2011-11-09 17:46:50 UTC
Two issues: 1) Resuming a partial download caused a refetch. We weren't handling the return HTTP code, so the partial download was being completed then discarded and we'd refetch. 2) We weren't handling refetches as described in bz 765930 Commit for #1 below http://git.fedorahosted.org/git/?p=grinder.git;a=commitdiff;h=4b2670430dff269837e396c6822679ae8269e283 See 765930 for commit for the refetch. QE: When you do resume a sync, look in grinder logs and verify that the resumed file successfully resumes. If it resumes, then drops the same file and refetches this issue is not fixed. build: 0.255 Fails_qa [root@preethi ~]# rpm -q pulp pulp-0.0.255-1.fc15.noarch [root@preethi ~]# with resumed sync I still see the following messages in grinder.log 2011-12-20 14:54:53,114 6961:139681362589440: grinder.ProgressTracker:ERROR: ProgressTracker:207 Negative delta_bytes <-107904.0>. download_total=<334356.0>, downloaded=<23168.0>, prev_remaining_bytes=<203284.0>, remaining_bytes=<311188.0>, total_size_bytes=<334356.0>, http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/Packages/eclipse-callgraph-0.8.0-1.fc16.x86_64.rpm 2011-12-20 14:54:53,117 6961:139681362589440: grinder.ProgressTracker:ERROR: ProgressTracker:207 Negative delta_bytes <-100664.0>. download_total=<334356.0>, downloaded=<30408.0>, prev_remaining_bytes=<203284.0>, remaining_bytes=<303948.0>, total_size_bytes=<334356.0>, http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/Packages/eclipse-callgraph-0.8.0-1.fc16.x86_64.rpm 2011-12-20 14:54:53,119 6961:139681362589440: grinder.ProgressTracker:ERROR: ProgressTracker:207 Negative delta_bytes <-94872.0>. download_total=<334356.0>, downloaded=<36200.0>, prev_remaining_bytes=<203284.0>, remaining_bytes=<298156.0>, total_size_bytes=<334356.0>, http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/Packages/eclipse-callgraph-0.8.0-1.fc16.x86_64.rpm 2011-12-20 14:54:53,131 6961:139681949783808: grinder.ProgressTracker:ERROR: ProgressTracker:207 Negative delta_bytes <-106616.0>. download_total=<131800.0>, downloaded=<2896.0>, prev_remaining_bytes=<22288.0>, remaining_bytes=<128904.0>, total_size_bytes=<131800.0>, http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/Packages/sil-gentium-basic-book-fonts-1.1-6.fc15.noarch.rpm 2011-12-20 14:54:53,131 6961:139681949783808: grinder.ProgressTracker:ERROR: ProgressTracker:207 Negative delta_bytes <-106616.0>. download_total=<131800.0>, downloaded=<2896.0>, prev_remaining_bytes=<22288.0>, remaining_bytes=<128904.0>, total_size_bytes=<131800.0>, http://download.devel.redhat.com/released/F-16/GOLD/Fedora/x86_64/os/Packages/sil-gentium-basic-book-fonts-1.1-6.fc15.noarch.rpm I believe the problem is that we were using an older Grinder when QE tested this. I made a mistake and did not bump the pulp.spec correctly to require Grinder 0.134 or newer, so grinder 0.128 was part of the QE build which didn't have the fix needed. Below change fixes this so Pulp now requires Grinder 0.136 http://git.fedorahosted.org/git/?p=pulp.git;a=commitdiff;h=548ad62d61d1b47cf079fa91ec5a713827681f0d QE: Please re-test with Grinder 0.136 build: 0.256 verified [root@preethi ~]# rpm -q pulp pulp-0.0.256-1.fc15.noarch [root@preethi ~]# 2012-01-06 14:58:57,037 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:191 Told thread <<WorkerThread(Thread-101, started daemon 140400685717248)>> to stop 2012-01-06 14:58:57,038 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:271 stop() invoked 2012-01-06 14:58:57,041 25671:140400132093696: grinder.ParallelFetch:INFO: ParallelFetch:308 WorkerThread deleting ActiveObject 2012-01-06 14:58:57,041 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:281 stop() completed 2012-01-06 14:58:57,041 25671:140400132093696: grinder.ParallelFetch:INFO: ParallelFetch:323 Thread ending 2012-01-06 14:58:57,041 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:191 Told thread <<WorkerThread(Thread-102, started daemon 140400132093696)>> to stop 2012-01-06 14:58:57,042 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:271 stop() invoked 2012-01-06 14:58:57,044 25671:140400123700992: grinder.ParallelFetch:INFO: ParallelFetch:308 WorkerThread deleting ActiveObject 2012-01-06 14:58:57,045 25671:140401194256128: grinder.ParallelFetch:INFO: ParallelFetch:281 stop() completed 2012-01-06 14:58:57,045 25671:140400123700992: grinder.ParallelFetch:INFO: ParallelFetch:323 Thread ending Pulp v1.0 is released Closed Current Release. Pulp v1.0 is released. |