Bug 752858 (perl-Qt)
| Summary: | Review Request: perl-Qt - Perl bindings for Qt | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| URL: | http://search.cpan.org/dist/Qt/ | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Qt-0.96.0-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-26 23:09:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2011-11-10 15:55:29 UTC
Review:- + koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3504521 + rpmlint on a package gave perl-Qt-devel.x86_64: W: file-not-utf8 /usr/share/doc/perl-Qt-devel-0.96.0/examples/tools/codecs/encodedfiles/iso-8859-1.txt perl-Qt-devel.x86_64: E: wrong-script-interpreter /usr/share/doc/perl-Qt-devel-0.96.0/examples/linguist/hellotr/hellotr.pro [0] perl-Qt-devel.x86_64: W: file-not-utf8 /usr/share/doc/perl-Qt-devel-0.96.0/examples/tools/codecs/encodedfiles/iso-8859-15.txt perl-Qt-devel.x86_64: W: no-manual-page-for-binary puic4 perl-Qt-devel.x86_64: W: no-manual-page-for-binary prcc4_bin perl-Qt-devel.x86_64: W: no-manual-page-for-binary qdbusxml2perl 3 packages and 0 specfiles checked; 1 errors, 5 warnings. + Source verified with upstream as (sha1sum) 147428a10da852e82c0da06307c3c45ac8dada88 Qt-0.96.0.tar.gz 147428a10da852e82c0da06307c3c45ac8dada88 ../SOURCES/Qt-0.96.0.tar.gz + make test gave 100% tests passed, 0 tests failed out of 26 Total Test time (real) = 6.11 sec + Follows packaging guidelines suggestions: 1) Fix the rpmlint warnings for file-not-utf8 for iso-8859-1.txt and iso-8859-15.txt. See http://fedoraproject.org/wiki/Packaging_tricks#Convert_encoding_to_UTF-8 2) Fix the rpmlint error as given above. APPROVED. (In reply to comment #2) > > suggestions: > 1) Fix the rpmlint warnings for file-not-utf8 for iso-8859-1.txt and > iso-8859-15.txt. That would ruin the point of the files - the example code demonstrates how to read and write files using various encodings. > > 2) Fix the rpmlint error as given above. That's not a script - and it's not executable. It just a text file that happens to start with a shebang. > APPROVED. Thanks! New Package SCM Request ======================= Package Name: perl-Qt Short Description: Perl bindings for Qt Owners: iarnell Branches: f15 f16 InitialCC: perl-sig Git done (by process-git-requests). perl-Qt-0.96.0-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Qt-0.96.0-1.fc16 perl-Qt-0.96.0-1.fc16 has been pushed to the Fedora 16 testing repository. perl-Qt-0.96.0-1.fc16 has been pushed to the Fedora 16 stable repository. |