Bug 752909

Summary:	Review Request: libverto - Main loop abstraction library
Product:	[Fedora] Fedora	Reporter:	Nathaniel McCallum <nathaniel>
Component:	Package Review	Assignee:	Stephen Gallagher <sgallagh>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, sgallagh
Target Milestone:	---	Flags:	sgallagh: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-11 22:17:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Nathaniel McCallum 2011-11-10 18:57:50 UTC

Spec URL: http://npmccallum.fedorapeople.org/libverto/libverto.spec
SRPM URL: http://npmccallum.fedorapeople.org/libverto/libverto-0.2.1-1.fc16.src.rpm

Description:
libverto provides a way for libraries to expose asynchronous interfaces
without having to choose a particular event loop, offloading this
decision to the end application which consumes the library.

If you are packaging an application, not library, based on libverto,
you should depend either on a specific implementation module or you
can depend on the virtual provides 'libverto-module-base'. This will
ensure that you have at least one module installed that provides io,
timeout and signal functionality. Currently glib is the only module
that does not provide these three because it lacks signal. However,
glib will support signal in the future.

Comment 1 Nathaniel McCallum 2011-11-10 19:01:40 UTC

Koji build against f17 available here: http://koji.fedoraproject.org/koji/taskinfo?taskID=3505386

Also, this package is a new dependency of mit krb5 1.10.

Comment 2 Stephen Gallagher 2011-11-10 21:46:09 UTC

[sgallagh@sgallagh520 review]$ rpmlint ~/rpmbuild/RPMS/x86_64/*.rpm
libverto.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii
libverto-devel.x86_64: W: no-documentation
libverto-glib.x86_64: W: summary-not-capitalized C glib module for libverto
libverto-glib.x86_64: W: no-documentation
libverto-glib-devel.x86_64: W: no-documentation
libverto-libev.x86_64: W: summary-not-capitalized C libev module for libverto
libverto-libev.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii
libverto-libev.x86_64: W: no-documentation
libverto-libev-devel.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii
libverto-libev-devel.x86_64: W: no-documentation
libverto-libevent.x86_64: W: summary-not-capitalized C libevent module for libverto
libverto-libevent.x86_64: W: no-documentation
libverto-libevent-devel.x86_64: W: no-documentation
libverto-tevent.x86_64: W: summary-not-capitalized C tevent module for libverto
libverto-tevent.x86_64: W: spelling-error %description -l en_US io -> oi, Io, ii
libverto-tevent.x86_64: W: no-documentation
libverto-tevent-devel.x86_64: W: no-documentation
11 packages and 0 specfiles checked; 0 errors, 17 warnings.

MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}

This is not met. The {?_isa} is missing.

So, fix that one minor issue and I will approve this.

Comment 3 Nathaniel McCallum 2011-11-11 17:34:46 UTC

Fixed.

Comment 4 Nathaniel McCallum 2011-11-11 18:23:03 UTC

Spec: http://npmccallum.fedorapeople.org/libverto/libverto.spec
SRPM: http://npmccallum.fedorapeople.org/libverto/libverto-0.2.1-2.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3508201

Comment 5 Stephen Gallagher 2011-11-11 18:31:03 UTC

Package is approved.

Comment 6 Stephen Gallagher 2011-11-11 18:32:44 UTC

New Package SCM Request
=======================
Package Name: libverto
Short Description: Main loop abstraction library
Owners: npmccallum
Branches: f16
InitialCC:

Comment 7 Gwyn Ciesla 2011-11-11 18:36:22 UTC

Git done (by process-git-requests).

Comment 8 Nathaniel McCallum 2011-11-11 22:17:59 UTC

Thanks!