Bug 753019

Summary:	Review Request: perl-Crypt-RC4-XS - Perl implementation of the RC4 encryption algorithm
Product:	[Fedora] Fedora	Reporter:	Mathieu Bridon <bochecha>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	notting, package-review, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-17 06:33:23 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mathieu Bridon 2011-11-11 03:30:52 UTC

Spec URL: http://bochecha.fedorapeople.org/packages/perl-Crypt-RC4-XS.spec
SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Crypt-RC4-XS-0.02-1.fc16.src.rpm
Description:
This module XS implementation of the RC4 algorithm, developed by RSA
Security, Inc. Here is the description from Wikipedia website:

In cryptography, RC4 (also known as ARC4 or ARCFOUR meaning Alleged RC4, see
below) is the most widely-used software stream cipher and is used in popular
protocols such as Secure Sockets Layer (SSL) (to protect Internet traffic)
and WEP (to secure wireless networks). While remarkable for its simplicity
and speed in software, RC4 is vulnerable to attacks when the beginning of the
output keystream is not discarded, or a single keystream is used twice; some
ways of using RC4 can lead to very insecure cryptosystems such as WEP.


$ rpmlint perl-Crypt-RC4-XS*
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US keystream -> key stream, key-stream, keystroke
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US cryptosystems -> cryptocrystalline, cryptonymous, cryptoanalysis
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US keystream -> key stream, key-stream, keystroke
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US cryptosystems -> cryptocrystalline, cryptonymous, cryptoanalysis
3 packages and 1 specfiles checked; 0 errors, 4 warnings.

Comment 1 Parag AN(पराग) 2011-11-16 06:03:09 UTC

Review:-

+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3518020
+ rpmlint on package gave
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US keystream -> key stream, key-stream, keystroke
perl-Crypt-RC4-XS.src: W: spelling-error %description -l en_US cryptosystems -> cryptograms
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US keystream -> key stream, key-stream, keystroke
perl-Crypt-RC4-XS.x86_64: W: spelling-error %description -l en_US cryptosystems -> cryptograms
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ source match with upstream as (sha1sum)
ab829726c1398c37dd6fa2e356f5bb785f2020e8  Crypt-RC4-XS-0.02.tar.gz
ab829726c1398c37dd6fa2e356f5bb785f2020e8  ../SOURCES/Crypt-RC4-XS-0.02.tar.gz

+ make test gave
All tests successful.
Files=2, Tests=19,  0 wallclock secs ( 0.02 usr  0.00 sys +  0.02 cusr  0.00 csys =  0.04 CPU)
+ Package: perl-Crypt-RC4-XS-0.02-1.fc17.x86_64
Provides: perl(Crypt::RC4::XS) = 0.02
Requires: libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) perl(AutoLoader) perl(Exporter) perl(XSLoader) perl(strict) perl(warnings) rtld(GNU_HASH)
+ Follows packaging guidelines

Suggestions:
1) you don't need following in Fedora now
%defattr(-,root,root,-)

APPROVED.

Comment 2 Mathieu Bridon 2011-11-16 08:32:13 UTC

> Suggestions:
> 1) you don't need following in Fedora now
> %defattr(-,root,root,-)

Right, I'll remove it.

> APPROVED.

Thanks!


New Package SCM Request
=======================
Package Name: perl-Crypt-RC4-XS
Short Description: Perl implementation of the RC4 encryption algorithm
Owners: bochecha
Branches: f16 el6
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2011-11-16 12:11:03 UTC

Git done (by process-git-requests).

Comment 4 Mathieu Bridon 2011-11-17 06:33:23 UTC

Thanks Jon for the vcs.

Package imported and built in all branches, closing.