Bug 753089

Summary:	yum localinstall doesn't exit with 1 if no packages exist
Product:	Red Hat Enterprise Linux 6	Reporter:	Alexander Todorov <atodorov>
Component:	yum	Assignee:	James Antill <james.antill>
Status:	CLOSED WONTFIX	QA Contact:	BaseOS QE Security Team <qe-baseos-security>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.2
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-20 20:15:22 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Alexander Todorov 2011-11-11 10:01:39 UTC

Description of problem:

# yum localinstall *.rpm
Loaded plugins: product-id, security, subscription-manager
Updating certificate-based repositories.
Setting up Local Package Process
Cannot open: *.rpm. Skipping.
Nothing to do

# echo $?
0



No *.rpm packages present in the directory where yum was executed but the return code is still 0 (success). A test case which uses the above command was returning false positives because of that. 


Version-Release number of selected component (if applicable):
yum-3.2.29-22.el6.noarch

How reproducible:
always

Steps to Reproduce:
1. mkdir /tmp/empty-dir
2. cd /tmp/empty-dir
2. yum localinstall *.rpm
3. echo $?
  
Actual results:
0

Expected results:
1

Additional info:

Comment 1 James Antill 2011-12-20 19:57:19 UTC

 I'm going to NAK this because it's annoyingly non-trivial, and the localinstall command is deprecated. The problem is that when we fail in the "install" command (the only one IIRC), we distinguish between "nothing installed because it's already installed" which is exit 0 ... and "nothing installed because we tried and failed" which is exit 1. Adding this logic to localinstall isn't that easy, as we'd need to keep track of why it "didn't install", and:

yum install ./*.rpm

...should already work fine.

Comment 2 RHEL Program Management 2011-12-20 20:15:22 UTC

Development Management has reviewed and declined this request.  You may appeal
this decision by reopening this request.