Bug 753155

Summary: RFE: implement logging to spice-xpi
Product: Red Hat Enterprise Linux 6 Reporter: David Jaša <djasa>
Component: spice-xpiAssignee: Peter Hatina <phatina>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: high    
Version: 6.2CC: acathrow, bsanford, cmeadors, cpelland, dblechte, iheim, mkrcmari, phatina, pvine, syeghiay, tsmetana, uril
Target Milestone: betaKeywords: FutureFeature, Improvement
Target Release: 6.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: spice-xpi-2.7-5.el6 Doc Type: Enhancement
Doc Text:
Some logging messages were added to spice-xpi, including spice-xpi functions called from the web page (javascript) and command line of processes that spice-xpi runs (e.g. spice-xpi-client)
 Story Points: ---
Clone Of: Environment:
Last Closed: 2012-06-20 14:48:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 756082    
Attachments:
Description Flags
spice-xpi add logging messages patch none

Description David Jaša 2011-11-11 13:23:51 UTC 
Description of problem:
SSIA. Current spice-xpi code contains only logging definitions in spice-xpi/SpiceXPI/src/plugin/debug.h lines 90-116, but it is used nowhere else and spice-xpi log is always empty.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Cameron Meadors 2011-11-16 16:43:16 UTC 
Can't debug bug 752111 without spice-xpi logging.
Comment 3 David Jaša 2011-11-16 16:50:39 UTC 
(In reply to comment #1)
> Can't debug bug 752111 without spice-xpi logging.

I found out that some logging can be enabled in /usr/share/spice/logger.ini by raising log level to DEBUG, R:

log4j.rootCategory=DEBUG, R

But it doesn't help with our Guest Hot Name issue though. :(
Comment 4 David Jaša 2011-11-17 00:03:35 UTC 
Peter, at the moment, we basically need logging of two kind of things:

1) whenever a web page calls spice-xpi function, log it including all variables that are passed to spice-xpi

2) when spice-xpi runs any other process (spicec, usbrdrctrl), log it including full command line

Both of these should be in INFO level.

It would be also great if the traffic on the controller could be logged, preferably full messages in DEBUG level. But this is of lower priority, if you don't have enough time, just clone it to some other bug so we have the two points above ASAP.
Comment 5 Itamar Heim 2011-11-20 11:20:33 UTC 
please make sure the Spice ActiveX gets the same level of logging
Comment 9 David Blechter 2011-12-15 18:07:22 UTC 
devel acked. considering 6.3 and not 6.2.z due to the time and resources limitationsl
Comment 11 Peter Hatina 2012-02-14 13:03:07 UTC 
Fixed.
Comment 14 Bill Sanford 2012-03-12 18:54:50 UTC 
Fixed in spice-xpi-2.7-13.el6.x86_64.
Comment 15 Uri Lublin 2012-06-03 11:57:28 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Some logging messages were added to spice-xpi, including spice-xpi functions called from the web page (javascript) and command line of processes that spice-xpi runs (e.g. spice-xpi-client)
Comment 16 Uri Lublin 2012-06-03 13:18:28 UTC 
Created attachment 588854 [details]
spice-xpi add logging messages patch
Comment 18 errata-xmlrpc 2012-06-20 14:48:08 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2012-0956.html