Bug 753453
| Summary: | Review Request: Field3D - Library for storing voxel data | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Shaw <hobbes1069> |
| Component: | Package Review | Assignee: | Mo Morsi <mmorsi> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mmorsi, notting, package-review |
| Target Milestone: | --- | Flags: | mmorsi:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Field3D-1.2.1-1.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-27 22:56:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Shaw
2011-11-12 17:19:43 UTC
Rpmlint output: Source RPM: Field3D.src: W: spelling-error Summary(en_US) voxel -> vowel Field3D.src: W: spelling-error %description -l en_US voxel -> vowel Field3D.src: W: invalid-url Source0: imageworks-Field3D-v1.2.0-0-gcbe4a23.tar.gz 1 packages and 0 specfiles checked; 0 errors, 3 warnings. The source comes from github so it's generated on the fly. Instructions are included in the spec file for obtaining the source. RPMS: $ rpmlint *.x86_64.rpm Field3D.x86_64: W: spelling-error Summary(en_US) voxel -> vowel Field3D.x86_64: W: spelling-error %description -l en_US voxel -> vowel Field3D.x86_64: W: no-manual-page-for-binary f3dinfo 3 packages and 0 specfiles checked; 0 errors, 3 warnings. I'm working with upstream to create a basic manpage for f3dinfo. Spec URL: http://hobbes1069.fedorapeople.org/Field3D/Field3D.spec SRPM URL: http://hobbes1069.fedorapeople.org/Field3D/Field3D-1.2.1-1.fc15.src.rpm Patch and manpage were accepted upstream. Taking this one As promised, reviewing this package * rpmlint looks good $ rpmlint /home/mmorsi/rpmbuild/RPMS/x86_64/Field3D-1.2.1-1.fc15.x86_64.rpm /home/mmorsi/rpmbuild/RPMS/x86_64/Field3D-devel-1.2.1-1.fc15.x86_64.rpm /home/mmorsi/rpmbuild/RPMS/x86_64/Field3D-debuginfo-1.2.1-1.fc15.x86_64.rpm rpmbuild/SRPMS/Field3D-1.2.1-1.fc15.src.rpm Field3D.x86_64: W: spelling-error Summary(en_US) voxel -> vowel Field3D.x86_64: W: spelling-error %description -l en_US voxel -> vowel Field3D.src: W: spelling-error Summary(en_US) voxel -> vowel Field3D.src: W: spelling-error %description -l en_US voxel -> vowel Field3D.src: W: invalid-url Source0: imageworks-Field3D-v1.2.1-0-g0790dc2.tar.gz 4 packages and 0 specfiles checked; 0 errors, 5 warnings. * koji is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3583433 * package performs are required as verified via the test suite and running the f3dinfo --help * package matches upstream source $ md5sum imageworks-Field3D-v1.2.1-0-g0790dc2.tar.gz ~/Downloads/imageworks-Field3D-v1.2.1-0-g0790dc2.tar.gz 9373b2a11df85a2b5cc4ab1f793493d4 imageworks-Field3D-v1.2.1-0-g0790dc2.tar.gz 9373b2a11df85a2b5cc4ab1f793493d4 /home/mmorsi/Downloads/imageworks-Field3D-v1.2.1-0-g0790dc2.tar.gz The package looks good, and complies to packaging guidelines. Good job. --------------- Field3D is APPROVED --------------- New Package SCM Request ======================= Package Name: Field3D Short Description: Library for storing voxel data Owners: hobbes1069 Branches: f15 f16 InitialCC: Thanks for the review! Git done (by process-git-requests). Mo, please take ownership of review BZs, thanks! My apologies, simply forgot. Took ownership. Field3D-1.2.1-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/Field3D-1.2.1-1.fc16 Field3D-1.2.1-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/Field3D-1.2.1-1.fc15 Field3D-1.2.1-1.fc16 has been pushed to the Fedora 16 testing repository. Field3D-1.2.1-1.fc16 has been pushed to the Fedora 16 stable repository. Field3D-1.2.1-1.fc15 has been pushed to the Fedora 15 stable repository. |