Bug 753677

Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514553
+ rpmlint on package gave
gnome-shell-extension-noa11y.noarch: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.noarch: W: invalid-url URL Note
gnome-shell-extension-noa11y.noarch: W: no-documentation
gnome-shell-extension-noa11y.noarch: W: empty-%postun
gnome-shell-extension-noa11y.src: W: no-version-in-last-changelog
gnome-shell-extension-noa11y.src: W: invalid-url URL Note
gnome-shell-extension-noa11y.src: E: invalid-spec-name
gnome-shell-extension-noa11y.src:2: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1)
gnome-shell-extension-noa11y.src: W: invalid-url Source0: noa11y.com.tar.gz
2 packages and 0 specfiles checked; 1 errors, 8 warnings.

suggestions:
1) you don't need now following in current active Fedora releases.
%defattr (-,root,root,-)

and in %install
rm -rf %{buildroot}

2) add the version-release information in changelog like
* Sun Nov 13 2011 Amir Hedayaty <hedayaty AT gmail DOT com>- 0-0.1
- Initial package for Fedora

3) you can remove warning mixed-use-of-spaces-and-tabs by using command
sed -e 's|\t| |g' gnome-shell-extension-noa11y.spec

3) I see you have wrong spec file added in srpm. you added gnome-shell-extension-no11y.spec whereas it should be gnome-shell-extension-noa11y.spec

4) you don't need %postun in spec file. remove that.

5) Host your tarball on some server and use that download url in URL of spec.


submit a new SPEC and SRPM by fixing above issues.

Thanks for the feedback I hope the issue are fixed!
Here are the new urls:

Spec URL:
www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y.spec
SRPM URL:
www.cs.sfu.ca/~aha49/personal/fedora/gnome-shell-extension-noa11y-3.2.0-1.src.rpm

Review:

+ koji scratch build for f17 -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3908553

+ rpmlint on rpms gave
gnome-shell-extension-noa11y.noarch: W: no-documentation
gnome-shell-extension-noa11y.src: W: invalid-url Source0: gnome-shell-extension-noa11y-3.2.0.tar.gz
2 packages and 0 specfiles checked; 0 errors, 2 warnings.

+ upstream source URL is verified as (sha1sum)
7e59257df57d226a9b8f950a33a48a5f8db57152  ../SOURCES/gnome-shell-extension-noa11y-3.2.0.tar.gz
7e59257df57d226a9b8f950a33a48a5f8db57152  gnome-shell-extension-noa11y-3.2.0.tar.gz

+ package follows guidelines.

Suggestions:
1)Source tag should 
Source0:        http://www.cs.sfu.ca/~aha49/personal/fedora/%{name}-%{version}.tar.gz

2) URL tag should contain a link where this project is hosted. If its nowhere hosted then remove the URL tag.

3) Any reason for not using disttag? See http://fedoraproject.org/wiki/Packaging:DistTag how to add dist-tag.

4) Package is installed successfully but unable to get extension working. Look like you need to modify metadata.json to include new gnome-shell versions. I tested on f17 and this is not working. After adding "3.3.90" as gnome-shell version it start working.


Please fix the suggestions before you add this package in dist-git.

submit a new srpm with new source and I will approve it.

Here are the new rpm files,

http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.spec
http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3.2.0-1.src.rpm

They are targeted for FC16 and gnome 3.2 again.
For gnome 3.4 I will update it hopefully soon! Existence of this extension is kind of ridiculous a similar one is the most popular extension on gnome! I wish gnome 3.4 added an option to hide that

Package must work on current development version. Please make sure your extensions will work in F17 and F18.

OK, the issue was solved somehow gnome-extension-tool did not enable the extensions! Here is the new version for gnome 3.4 and FC17
https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed-3.4.10-1.src.rpm
https://github.com/downloads/hedayaty/NetSpeed/gnome-shell-extension-netspeed.spec

Oops Sorry messed them up! 
Here is the noa11y for gnome 3.4

https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3.4.0-1.src.rpm
https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.spec

koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3996999

Fix the rpmlint warning
gnome-shell-extension-noa11y.noarch: W: incoherent-version-in-changelog 3.4.0 ['3.4.0-1', '3.4.0-1']
The latest entry in %changelog contains a version identifier that is not
coherent with the epoch:version-release tuple of the package.

unable to verify sources
wget http://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3.4.0.tar.gz 
==> ERROR 404: Not Found.

one last thing, maybe I had overlooked but where can I see the license to verify? I see no separate license text file available in tarball, no license headers included in .js


you need to change 3.4.0 to 3.4.0-1 to fix rpmlint warning.

Added copyright here as well

https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y.spec

https://github.com/downloads/hedayaty/No-A11y/gnome-shell-extension-noa11y-3.4.0-2.src.rpm

https://github.com/downloads/hedayaty/No-A11y/noa11y@hedayaty.gmail.com.tar.gz

rpmlint still shows 

gnome-shell-extension-noa11y.noarch: W: incoherent-version-in-changelog 3.4.0 ['3.4.0-2', '3.4.0-2']

Please read http://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs

Anyway, I will not wait for this to get fixed.

APPROVED.

any update here?

any update here?

If I will not hear any updates in next one week, will close this as NOTABUG