Bug 753825

Summary: Quaff a hallucinogenic potion and corrupt your save file
Product: [Fedora] Fedora Reporter: Jacek Piskozub <piskozub>
Component: rogueAssignee: Alexandre Moine <nobrakal>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 24CC: wart
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2017-08-08 11:39:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
The save file still not corrupted but in a state where it is easy to reproduce the crash
none
Fix the bug (test for null pointer)
none
New patch, test only what is needed none

Description Jacek Piskozub 2011-11-14 15:44:12 UTC
Created attachment 533556 [details]
The save file still not corrupted but in a state where it is easy to reproduce the crash

Description of problem:

After quaffing a cyan potion and saving the game it is impossible to restart using the save file


Version-Release number of selected component (if applicable):
rogue-5.4.5-7.fc15.i686

How reproducible:

Every time


Steps to Reproduce:

1. Start the game loading the provided save file ("rogue -r")
2. Quaff the cyan potion (type "q" and then "n")
3. See the game say "Oh, wow!  Everything seems so cosmic!" (meaning you drank a hallucinogenic potion)
4. Save the game (type "S" and then "y")
5. Repeat point 1.
6. Watch the segmentation fault
  

Actual results:

The game crashes instantly leaving on screen the following garbled message: "File name: rogue.saveSegmentation fault"


Expected results:

The game can be continued (albeit with hallucinations about what monster species you accost because you just drank a hallucinogenic potion) 


Additional info:

Drinking any other potion does not have the effect.

Doing the same at a later moment does not help (the save file is corrupted as well).

Comment 1 Jacek Piskozub 2011-11-14 16:00:49 UTC
May be related to the allegedly solved bug 560790 (same behavior, different artifact)

Comment 2 Fedora Admin XMLRPC Client 2012-01-11 08:33:57 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 3 Fedora End Of Life 2012-08-07 18:06:37 UTC
This message is a notice that Fedora 15 is now at end of life. Fedora
has stopped maintaining and issuing updates for Fedora 15. It is
Fedora's policy to close all bug reports from releases that are no
longer maintained. At this time, all open bugs with a Fedora 'version'
of '15' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we were unable to fix it before Fedora 15 reached end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged to click on
"Clone This Bug" (top right of this page) and open it against that
version of Fedora.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

The process we are following is described here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora End Of Life 2013-04-03 19:40:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 5 Fedora End Of Life 2015-01-09 21:54:08 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 6 Fedora End Of Life 2015-11-04 15:45:19 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 7 Jacek Piskozub 2015-11-20 16:35:34 UTC
Works for me now. It may be closed.

Comment 8 Petr Šabata 2015-11-23 12:54:25 UTC
(In reply to Jacek Piskozub from comment #7)
> Works for me now. It may be closed.

I can still reproduce it; what version are you using?

Comment 9 Jacek Piskozub 2015-11-23 14:59:22 UTC
rogue-5.4.5-16.fc22.i686

However I'll clarify that I tested it on the file I submitted at the top of the thread. I did not play rogue for a long enough time to hit this if it still happens.

Comment 10 Petr Šabata 2015-11-23 15:58:33 UTC
Thanks.  Noted.

Just for reference, I used the same file with rogue-5.4.5-18.fc23.x86_64 and it still crashed.

Comment 11 Jan Kurik 2016-02-24 15:30:08 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 12 Fedora Admin XMLRPC Client 2016-03-12 16:07:33 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 13 Fedora Admin XMLRPC Client 2016-03-12 16:44:04 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 14 Alexandre Moine 2017-02-24 10:43:41 UTC
Created attachment 1257190 [details]
Fix the bug (test for null pointer)

Comment 15 Alexandre Moine 2017-02-24 10:47:37 UTC
Hi, just made a little patch, that check if monsters in the save file are correct (because the bug came from null pointer in daemon.c:103, who came from the save file ).

Please tell me if it works for you.

But this patch doesn't tell us from where came the bug...

In all case, I will upload this patch if you allow me to, or, if I don't have any response within two/three weeks, because this is an old bug.

Thank you.

Comment 16 Alexandre Moine 2017-02-24 10:58:11 UTC
Created attachment 1257191 [details]
New patch, test only what is needed

Comment 17 Fedora End Of Life 2017-07-25 18:29:13 UTC
This message is a reminder that Fedora 24 is nearing its end of life.
Approximately 2 (two) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 24. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '24'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 24 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 18 Fedora End Of Life 2017-08-08 11:39:59 UTC
Fedora 24 changed to end-of-life (EOL) status on 2017-08-08. Fedora 24 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.