| Summary: | Fix kvm userspace compilation on RHEL-5 to match the kernel changes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 5 | Reporter: | Michal Novotny <minovotn> | ||||
| Component: | kvm | Assignee: | Michal Novotny <minovotn> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 5.8 | CC: | areis, bgollahe, ehabkost, juzhang, michen, mkenneth, rhod, shuang, tburke, virt-maint, xfu | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | kvm-83-245.el5 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-02-21 03:15:18 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Attachments: |
|
||||||
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. http://rhn.redhat.com/errata/RHSA-2012-0149.html |
1.reproduce with kvm-243 steps to reproduce 1.1) review kvm-243 source code(kvm-userspace-rhel5/kernel/external-module-compat.c) > ts.tv_sec = div_long_long_rem_signed(nsec, NSEC_PER_SEC, &ts.tv_nsec); > if (unlikely(nsec < 0)) > kvm_set_normalized_timespec(&ts, ts.tv_sec, ts.tv_nsec); 1.2) compile kvm-243 /root/kvm-userspace-rhel5/kernel/x86/../external-module-compat.c:284: warning: ‘kvm_set_normalized_timespec’ defined but not used actual result: broke the compilation of the KVM userspac 2. verify with kvm-246 steps to verify: 2.1)review kvm-246 source code < s32 rem; < ts.tv_sec = div_s64_rem(nsec, NSEC_PER_SEC, &rem); < if (unlikely(rem < 0)) { < ts.tv_sec--; < rem += NSEC_PER_SEC; < } < ts.tv_nsec = rem; 2.2)compile kvm-246 actual result: compile successfully,and make install successfully too. base on above testing result, I think this bug is fixed.