Bug 753900

Review:-
+ koji build ->http://koji.fedoraproject.org/koji/taskinfo?taskID=3514557
+ rpmlint on package gave
abi-compliance-checker.src:27: W: rpm-buildroot-usage %prep sed -i "s,\$PREFIX/share/\$TOOL_SNAME,%{buildroot}%{perl_vendorlib}/\$TOOL_SNAME,g" Makefile.pl
abi-compliance-checker.noarch: E: zero-length /usr/share/perl5/vendor_perl/abi-compliance-checker/modules/RulesSrc.xml
abi-compliance-checker.noarch: W: no-manual-page-for-binary abi-compliance-checker
2 packages and 0 specfiles checked; 1 errors, 2 warnings.
==> looks ok and can be ignored for this package

+ Source match with upstream as (sha1sum)
4fe5ecf074faac8e46a6e8af9ee6a00d9c2470c6  abi-compliance-checker-1.95.9.tar.gz
4fe5ecf074faac8e46a6e8af9ee6a00d9c2470c6  ../SOURCES/abi-compliance-checker-1.95.9.tar.gz
+ Follows packaging guidelines.

Suggestions:
1)license looks to be GPLv2+. Good to ask upstream to add license text in perl files also.
2) you don't need now in Fedora spec following
%install
rm -rf %{buildroot}

Please don't change the module install path to %{perl_vendorlib}. It's not
installing real Perl modules - just a bunch of xml files and a couple of
private-use Perl libraries. It's more appropriate to install them under
/usr/share as upstream intended. And consequently, it's not necessary to
require perl(:MODULE_COMPAT...).

License actually looks to be "GPLv2 or LGPLv2" according to usage text in abi-compliance-checker.pl itself (which matches the version of included license texts).

Thanks for your comment Iain. yes license should be "GPLv2+ or LGPLv2+" See http://fedoraproject.org/wiki/Packaging:LicensingGuidelines#.22or_later_version.22_licenses

I have updated everything but need clarification. Iain says it's "GPLv2 or LGPLv2" whereas you're saying it's "GPLv2+ or LGPLv2+", but I agree with Iain here. I did not see any text in the license file that indicated it was forward compatible. 

SPEC: http://hobbes1069.fedorapeople.org/abi-compliance-checker/abi-compliance-checker.spec
SRPM: http://hobbes1069.fedorapeople.org/abi-compliance-checker/abi-compliance-checker-1.95.9-2.fc15.src.rpm

Looking again, both LICENSE.txt and doc/Readme.html state "GPL or LGPL" without mentioning the version - which technically means any version, i.e. "GPL+ or LGPLv2+". The comments in abi-compliance-checker.pl header contain "either version 2 of the Licenses, or any later version", while the usage text in the code simply says "GPLv2 or LGPLv2".

The best solution is to ask upstream to clarify the situation.

(In reply to comment #5)
> The best solution is to ask upstream to clarify the situation.

I've emailed the primary developer. Do we want to hold up the review for this? I can update the spec once I receive an answer. Since it is unlikely that anyone will be building against this as a library it should affect any other packages.

If we can continue, which license(s) should we reference? Isn't there a order of precedence for situations like this?

Thanks,
Richard

Looking into https://fedoraproject.org/wiki/Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F

Go with what Iain said "GPLv2 or LGPLv2".

I got an answer:

From: Andrey Ponomarenko <aponomarenko>

Hello,

This is great news, that this tool will be a part of such a popular 
Fedora operating system. Very thanks for your work.

The answer for your question is: dual GPL or LGPL of any versions. I've 
corrected it in the new release (1.95.10 [1-2]).

[1] http://forge.ispras.ru/projects/abi-compliance-checker/files
[2] http://forge.ispras.ru/svn/abi-compliance-checker

---

Does this make it "GPL+ or LGPLv2+"?

Thanks,
Richard

(In reply to comment #8)
> 
> Does this make it "GPL+ or LGPLv2+"?

Yes.

New Package SCM Request
=======================
Package Name: abi-compliance-checker
Short Description: An ABI Compliance Checker
Owners: hobbes1069
Branches: f15 f16
InitialCC: perl-sig

Git done (by process-git-requests).

abi-compliance-checker-1.95.10-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/abi-compliance-checker-1.95.10-1.fc16

abi-compliance-checker-1.95.10-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/abi-compliance-checker-1.95.10-1.fc15

abi-compliance-checker-1.95.10-1.fc16 has been pushed to the Fedora 16 testing repository.

abi-compliance-checker-1.95.10-1.fc15 has been pushed to the Fedora 15 stable repository.

abi-compliance-checker-1.95.10-1.fc16 has been pushed to the Fedora 16 stable repository.

I'd like to see this in EPEL 6.  Richard, do you have any interest in maintaining there, or shall I?

Hmm, is the gcc >= 4.5 a hard requirement?

(In reply to comment #17)
> I'd like to see this in EPEL 6.  Richard, do you have any interest in
> maintaining there, or shall I?

You're more than welcome to. I thought it would probably be nice to have but they release fairly frequently so keeping it up to date with the 2 week waiting period in testing could get fairly laborious but probably worth it.

In fact I just got 1.97.5 into stable and just today I got the auto-bug-report that 1.97.7 is released :)

(In reply to comment #18)
> Hmm, is the gcc >= 4.5 a hard requirement?

No, it looks to be just a recommendation. We can either maintain the EPEL version separately or use a macro to adjust it on the fly?

%if 0%{?fedora}
Requires: gcc >= 4.5
%else
Requires: gcc
%endif

???

The other option is just to remove the version since all supported fedora releases already meet it.

I think just removing the version requirement is the way to go.  Thanks!

Package Change Request
======================
Package Name: abi-compliance-checker
New Branches: el6
Owners: orion
InitialCC:

Sounds like a plan!

I set the cvs flag for you, I forget that all the time :)

Git done (by process-git-requests).