Bug 754088

I'm sorry for confusing, but this package doesn't depend on python-mimeparse. It's "restauth" package which has that dependency.

MUST items:
[YES] rpmplint is silent
[YES] Package meets naming guidelines.
[YES] Package meets packaging guidelines.
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[!] Spec file is legible and in American English.
  I would prefer summary like: Python module containing small set of classes
  used by both RestAuth server/client implementations
  or similar.
  
  Description differs for python and python3! The python3 description is probably for the restauth itself.

[YES] Sources match upstream.
[YES] Package builds OK.
[!] BuildRequires are correct.
I cannot find the python-setuptools-devel in rawhide.
Is the python-setuptools really needed? It seems to build OK without it.

[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[NO] Spec file has consistant macro usage.
  Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead of %{buildroot}.
[YES] Package is code or permissible content.
[YES] %doc files don't affect runtime.
[YES] Package doesn't own files/directories that other packages own.
[YES] All files are valid UTF-8.

Should items:
[YES] Package builds in mock.
[YES] Package uses sane scriptlets.

Some more comments:
There is extra space in both %doc (only cosmetic issue :)

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
is probably not needed any more.

The defattr is also not needed.

AFAIK the above have only sense if it is planned to package for RHEL-5 EPEL. If so there should be also more additions (e.g. %clean section, ...).

Please consider building and packaging the docs.

All mentioned problem should be fixed in:

Spec URL: http://jkaluza.fedorapeople.org/python-restauth-common.spec
SRPM URL:
http://jkaluza.fedorapeople.org/python-restauth-common-0.5.1-2.fc16.src.rpm

Several new warnings pops up now:
python-restauth-common-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-restauth-common-doc-0.5.1/html/.buildinfo
python-restauth-common.noarch: E: summary-too-long C Python module containing small set of classes used by both RestAuth server/client implementations
python-restauth-common.src: E: summary-too-long C Python module containing small set of classes used by both RestAuth server/client implementations
python3-restauth-common.noarch: E: summary-too-long C Python module containing small set of classes used by both RestAuth server/client implementations

The requires for doc should be probably changed to:
Requires: python-restauth-common = %{version}-%{release}

The %files -n python3-restauth-common still contains %defattr.

I think, you shouldn't package doctrees cache.

All the new bugs should be fixed in:
Spec URL: http://jkaluza.fedorapeople.org/python-restauth-common.spec
SRPM URL:
http://jkaluza.fedorapeople.org/python-restauth-common-0.5.1-3.fc16.src.rpm

Looks OK for me, giving fedora-review +

New Package SCM Request
=======================
Package Name: python-restauth-common
Short Description: Collects various code used in RestAuth server/client implementations
Owners: jkaluza
Branches: f15 f16
InitialCC: jskarvad

Git done (by process-git-requests).

python-restauth-common-0.5.1-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-restauth-common-0.5.1-3.fc16

python-restauth-common-0.5.1-3.fc16 has been pushed to the Fedora 16 testing repository.

python-restauth-common-0.5.1-3.fc16 has been pushed to the Fedora 16 stable repository.