Bug 754092

MUST items:
[YES] rpmplint is silent
[YES] Package meets naming guidelines.
[YES] Package meets packaging guidelines
  I am not sure about the API/ABI compatibility policy of this project.
  Shouldn't be there version requirement for python-restauth-common?
[YES] Spec file matches base package name.
[YES] License file is present, matching with spec file.
[YES] Licensing Guidelines are met.
[!] Spec file is legible and in American English.
  I would prefer summary like: "Reference implementation of RestAuth specification in Python"
  or similar

  I would tune the description a bit. I wouldn't note the python versions there and I would probably re-word the text. Maybe you could also very briefly describe what the RestAuth is (e.g. "The RestAuth project is a system providing shared authentication, authorization and preferences.").
[YES] Sources match upstream.
[YES] Package builds OK.
[!] BuildRequires are correct.
  I cannot find the python-setuptools-devel in rawhide.
  Is the python-setuptools really needed? It seems to build OK without it.

[YES] Package doesn't bundle copies of system libraries.
[YES] Package owns all the directories it creates.
[YES] Package has no duplicity in %files.
[YES] Permission on files are set properly.
[NO] Spec file has consistant macro usage.
  Please use %{optflags} instead of $RPM_OPT_FLAGS or $RPM_BUILD_ROOT instead of %{buildroot}.
[YES] Package is code or permissible content.
[YES] %doc files don't affect runtime.
[YES] Package doesn't own files/directories that other packages own.
[YES] Spec file is valid UTF-8.

Should items:
[YES] Package builds in mock.
[YES] Package uses sane scriptlets.

Some more comments:
There is extra space in the second %doc (only cosmetic issue :)

%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib()")}
is probably not needed any more.

The defattr is also not needed.

AFAIK the above have only sense if it is planned to package for RHEL-5 EPEL. If so there should be also more additions (e.g. %clean section, ...).

Please consider running the included test-suite as a part of the build process.

Please consider packaging the docs.

Please consider packaging the example script.

Version 0.5.1 of python-restauth depends on python-restauth-common >= 0.5.1. (The versions are not by definition the same, they just happen to coincide).

greetings, Mati

Fixed specfile and srpm:

Spec URL: http://jkaluza.fedorapeople.org/python-restauth.spec
SRPM URL: http://jkaluza.fedorapeople.org/python-restauth-0.5.1-2.fc16.src.rpm

I think all problems should be fixed. test-suite is not run, because it's currently broken. Upstream has been informed and I will use it when it will work again.

Is the BuildRequires:  python3-setuptools needed? It seems to build OK without it. Also consider packaging demo script from examples (its shebang would probably require tweaking).

Fixed specfile and srpm:

Spec URL: http://jkaluza.fedorapeople.org/python-restauth.spec
SRPM URL: http://jkaluza.fedorapeople.org/python-restauth-0.5.1-3.fc16.src.rpm

Examples should be included and setuptools removed.

Looks OK to me, giving fedora_review +. You could use the sed -i, to simplify the code for shebang removal.

New Package SCM Request
=======================
Package Name: python-restauth
Short Description: reference implementation of RestAuth specification in Python
Owners: jkaluza
Branches: f15 f16
InitialCC:

Git done (by process-git-requests).

python-restauth-0.5.1-3.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-restauth-0.5.1-3.fc16

python-restauth-0.5.1-3.fc16 has been pushed to the Fedora 16 testing repository.

python-restauth-0.5.1-3.fc16 has been pushed to the Fedora 16 stable repository.