Bug 754191
| Summary: | Review Request: gnome-search-tool - Utility for finding files for GNOME | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kparal, mclasen, metherid, rvokal, tiagomatos |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-02-28 12:06:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
fedoraparked
2011-11-15 16:41:59 UTC
Doesn't build in mock, due to a bunch of missing BuildRequires. intltool glib2-devel gtk3-devel gconf2-devel gnome-doc-utils probably more. Looking briefly at the spec: rm -rf $RPM_BUILD_ROOT in %install is no longer necessary %post and %postun scriptlets for the gconf schemas are missing %doc files such as AUTHORS COPYING README should be added to the file listing Spec and SRPM updated to fit in asked details. Cleaner code. Built on mock. No errors on rpmlint either. :) Please build using koji scratch build and post the url. Also, whenever you updated the spec, you should bump up the release, build the srpm and post the new url instead of updating in place. That didn't take much time: http://koji.fedoraproject.org/koji/taskinfo?taskID=3523061 Sorry for taking so long to getting back to this... Builds fine in mock now. Here's the rpmlint output: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-search-tool-*.rpm gnome-search-tool.src: W: spelling-error %description -l en_US filename -> file name, file-name, filament gnome-search-tool.src: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters gnome-search-tool.x86_64: W: spelling-error %description -l en_US filename -> file name, file-name, filament gnome-search-tool.x86_64: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters gnome-search-tool.x86_64: W: non-conffile-in-etc /etc/gconf/schemas/gnome-search-tool.schemas gnome-search-tool.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-search-tool-3.3.1/COPYING.docs gnome-search-tool.x86_64: E: incorrect-fsf-address /usr/share/doc/gnome-search-tool-3.3.1/COPYING gnome-search-tool.x86_64: W: dangerous-command-in-%pre rm gnome-search-tool.x86_64: W: dangerous-command-in-%post rm gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/libgnomeui-deprecated/gsearchtool-entry.h gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/libgnomeui-deprecated/gsearchtool-entry.c gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/libeggsmclient/eggdesktopfile.c gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool-support.c gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool.h gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool-support.h gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/libeggsmclient/eggdesktopfile.h gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool.c gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool-callbacks.h gnome-search-tool-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/gnome-search-tool-3.3.1/src/gsearchtool-callbacks.c 3 packages and 0 specfiles checked; 12 errors, 7 warnings. All of these are fine package name: ok spec file name: ok packaging guidelines: - given that there is not gsettings schema in the package, the glib-compile-schemas calls in %postun/%posttrans are pointless and should be removed - packaging ABOUT-NLS is not really useful, I'd leave that out package license: ok license field: - the license field should be "GPLv2+ and GFDL", I think. All the sources have an 'or later' clause, and the docs are under the fdl license file: ok spec language: ok spec readable: ok upsteram sources: ok buildable: ok ExludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok directory ownership: - looks like you need to own /usr/share/pixmaps/gsearchtool duplicate files: ok file permissions: ok macro use: ok large docs: ok %doc content: ok header files: ok static libs: ok shared libs: ok devel package: ok libtool archives: ok desktop files: ok duplicate ownership: ok utf8 filenames: ok summary: a few things to fix I've updated this. spec: http://glua.ua.pt/~rmatos/gnome-search-tool.spec srpm: http://glua.ua.pt/~rmatos/gnome-search-tool-3.3.1-2.fc16.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=3854704 Looks good now. Approved One small improvement you could still make is to use the GConf macros: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GConf But you can do that when building the package, since it is approved. New Package SCM Request ======================= Package Name: gnome-search-tool Short Description: Utility for finding files for GNOME Owners: rtcm Branches: InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: gnome-search-tool New Branches: f17 Owners: rtcm Git done (by process-git-requests). gnome-search-tool-3.3.1-4.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gnome-search-tool-3.3.1-4.fc17 gnome-search-tool-3.3.1-4.fc17 has been pushed to the Fedora 17 testing repository. gnome-search-tool-3.3.1-5.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gnome-search-tool-3.3.1-5.fc17 The package is in Fedora, I believe this should be closed. |