Bug 754379

Summary:	Stacktrace deleting server.
Product:	[Community] Spacewalk	Reporter:	Arjen Heidinga <dexter>
Component:	WebUI	Assignee:	Tomas Lestach <tlestach>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Red Hat Satellite QA List <satqe-list>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	1.5	CC:	dexter, slukasik
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	spacewalk-web-1.6.28-1	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-22 16:46:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	723481

Description Arjen Heidinga 2011-11-16 10:19:36 UTC

Description of problem:
I tried deleting a server from the Scheduled Tasks website part. It failed. I will paste the mail I got below. It worked when I deleted the server from the 'systems' part.

How reproducible:
alwayas

Steps to Reproduce:
1. Create a server, install it, put client on it. Do some scheduled tasks on t.
2. Turn that server off (to be deleted)
3. Schedule a task on multiple systems, including the turned off one.
4. After some time the one server will still be pending, while the rest is done/failed.
5. click on on the one failed, discover is was the shutoff server -> click it.
6. click 'delete system', en presto: a traceback.
  
Actual results:
Stacktrace

Expected results:
System deleted

Additional info:
The following exception occurred while executing this request:
GET /rhn/WEB-INF/pages/common/errors/badparam.jsp

Date:11/16/11 11:04:32 AM CET
Headers:
  host: bigbrother
  user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0.1) Gecko/20100101 Firefox/7.0.1
  accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
  accept-language: en-us,en;q=0.5
  accept-encoding: gzip, deflate
  accept-charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
  connection: keep-alive
  referer: https://bigbrother/network/systems/details/history/event.pxt?sid=1000010362&hid=22666
  cookie: JSESSIONID=15D4896F1CBE7BD097F7A07FFB7A9745; PHPSESSID=c4761i7gb0cjs5qug571p6k8m6; pxt-session-cookie=3755xf15a6847b56d5b8892aa93a4c189cae2

Request:
Local Name = bigbrother
Server Name = bigbrother
Requested Session Id came from Cookie
Requested Session Valid = true
Session = org.apache.catalina.session.StandardSessionFacade@189b698d[session=StandardSession[15D4896F1CBE7BD097F7A07FFB7A9745]]
Protocol = https
Request Locale = en_US
Request Character Encoding = UTF-8
Attribute Names = rhnActiveLang, javax.servlet.forward.request_uri, javax.servlet.forward.context_path, javax.servlet.forward.servlet_path, javax.servlet.forward.query_string, javax.servlet.jsp.jstl.fmt.timeZone.request, error, submittedForm, javax.servlet.request.key_size, requestedUri, javax.servlet.request.ssl_session, org.apache.struts.action.MESSAGE, session, __sitemesh__filterapplied, org.apache.struts.action.EXCEPTION, javax.servlet.request.cipher_suite, org.apache.struts.action.mapping.instance, org.apache.struts.action.MODULE, 


User Information:
User operations (id 1, org_id 1)

Exception:
com.redhat.rhn.frontend.action.common.BadParameterException: The parameter sid must be a Long, but was '?sid=1000010362'
	at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
	at java.lang.Long.parseLong(Long.java:438)
	at java.lang.Long.valueOf(Long.java:535)
	at com.redhat.rhn.frontend.struts.RequestContext.getParamAsLong(RequestContext.java:456)
	at com.redhat.rhn.frontend.struts.RequestContext.getRequiredParam(RequestContext.java:477)
	at com.redhat.rhn.frontend.action.systems.sdc.SystemDeleteConfirmAction.execute(SystemDeleteConfirmAction.java:59)
	at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431)
	at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:237)
	at com.redhat.rhn.frontend.struts.RhnRequestProcessor.process(RhnRequestProcessor.java:99)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196)
	at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.redhat.rhn.frontend.servlets.AuthFilter.doFilter(AuthFilter.java:117)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.opensymphony.module.sitemesh.filter.PageFilter.parsePage(PageFilter.java:142)
	at com.opensymphony.module.sitemesh.filter.PageFilter.doFilter(PageFilter.java:58)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.redhat.rhn.frontend.servlets.LocalizedEnvironmentFilter.doFilter(LocalizedEnvironmentFilter.java:67)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.redhat.rhn.frontend.servlets.EnvironmentFilter.doFilter(EnvironmentFilter.java:108)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.redhat.rhn.frontend.servlets.SessionFilter.doFilter(SessionFilter.java:55)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at com.redhat.rhn.frontend.servlets.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:97)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:215)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:172)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
	at org.apache.jk.server.JkCoyoteHandler.invoke(JkCoyoteHandler.java:200)
	at org.apache.jk.common.HandlerRequest.invoke(HandlerRequest.java:291)
	at org.apache.jk.common.ChannelSocket.invoke(ChannelSocket.java:775)
	at org.apache.jk.common.ChannelSocket.processConnection(ChannelSocket.java:704)
	at org.apache.jk.common.ChannelSocket$SocketConnection.runIt(ChannelSocket.java:897)
	at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
	at java.lang.Thread.run(Thread.java:636)

Comment 1 Tomas Lestach 2011-11-16 12:00:41 UTC

Can you reproduce the problem with another system?

Can you state the page/url, on that you clicked the 'delete system' link?

Comment 2 Arjen Heidinga 2011-11-16 12:09:55 UTC

Yes I can reproduce.

URLs:
Schedule page: 
   https://xxxxxxxxx/rhn/schedule/InProgressSystems.do?aid=22667
I click on a system, and go to:
   https://xxxxxxxxx/network/systems/details/history/event.pxt?sid=1000010163&hid=22667
From that page I click 'Delete system', which sends me to:
   https://xxxxxxxxx/rhn/systems/details/DeleteConfirm.do?sid=?sid=1000010163

Comment 3 Tomas Lestach 2011-11-16 12:39:41 UTC

Yes, valid issue.

Fixed ...
spacewalk.git: e3680049ee955aa666e1d93f1cb30e6fb567cb2b

Comment 4 Milan Zázrivec 2011-12-22 16:46:55 UTC

Spacewalk 1.6 has been released.