Bug 754436
| Summary: | Review Request: libvirt-glib - libvirt glib integration for event | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Daniel Berrangé <berrange> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | mclasen, notting, package-review |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-11-28 18:16:26 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Daniel Berrangé
2011-11-16 13:54:15 UTC
Builds fine in mock rpmlint output: rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm libvirt-gconfig.x86_64: W: summary-not-capitalized C libvirt object APIs for processing object configuration libvirt-gconfig.x86_64: W: no-documentation libvirt-gconfig.x86_64: E: library-without-ldconfig-postin /usr/lib64/libvirt-gconfig-1.0.so.0.0.1 libvirt-gconfig.x86_64: E: library-without-ldconfig-postun /usr/lib64/libvirt-gconfig-1.0.so.0.0.1 libvirt-gconfig-devel.x86_64: W: summary-not-capitalized C libvirt object APIs for processing object configuration development files libvirt-glib.src: W: summary-not-capitalized C libvirt glib integration for events libvirt-glib.x86_64: W: summary-not-capitalized C libvirt glib integration for events libvirt-glib.x86_64: E: incorrect-fsf-address /usr/share/doc/libvirt-glib-0.0.1/COPYING libvirt-glib.x86_64: E: library-without-ldconfig-postin /usr/lib64/libvirt-glib-1.0.so.0.0.1 libvirt-glib.x86_64: E: library-without-ldconfig-postun /usr/lib64/libvirt-glib-1.0.so.0.0.1 libvirt-glib-devel.x86_64: W: summary-not-capitalized C libvirt glib integration for events development files libvirt-glib-python.x86_64: W: summary-not-capitalized C libvirt glib integration for events python binding libvirt-glib-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtglibmod.so libvirtglibmod.so()(64bit) libvirt-glib-python.x86_64: W: devel-file-in-non-devel-package /usr/lib64/python2.7/site-packages/libvirtglibmod.a libvirt-gobject.x86_64: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization libvirt-gobject.x86_64: W: summary-not-capitalized C libvirt object APIs for managing virtualization hosts libvirt-gobject.x86_64: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization libvirt-gobject.x86_64: W: no-documentation libvirt-gobject.x86_64: E: library-without-ldconfig-postin /usr/lib64/libvirt-gobject-1.0.so.0.0.1 libvirt-gobject.x86_64: E: library-without-ldconfig-postun /usr/lib64/libvirt-gobject-1.0.so.0.0.1 libvirt-gobject-devel.x86_64: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization libvirt-gobject-devel.x86_64: W: summary-not-capitalized C libvirt object APIs for managing virtualization hosts development files libvirt-gobject-devel.x86_64: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization 9 packages and 0 specfiles checked; 7 errors, 16 warnings. Quick preliminary review of the spec file: I guess you are aiming for building on old releases as well, which explains why you have rm -rf $RPM_BUILD_ROOT in %install and a %clean section. In F16/F17, these are no longer needed. ldconfig in %post/%postun is indeed missing Is the 2008 date in %changelog a typo ? Updated SRPM & specfile http://berrange.fedorapeople.org/review/libvirt-glib/libvirt-glib-0.0.1-2.fc15.src.rpm http://berrange.fedorapeople.org/review/libvirt-glib/libvirt-glib.spec - Added missing ldconfig invocation for all sub-RPMs with libraries - Fixed bogus changelog date - Fixed conditional which accidentally allowed the -python library to be enabled on Fedora > 15 FYI, I will fix the FSF address in COPYING in next upstram release. And yes, the buildroot cleanup is so that this also builds on F15 distros. It can be removed in the future when that goes unsupported. Builds fine in mock, rpmlint output: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm libvirt-gconfig.x86_64: W: summary-not-capitalized C libvirt object APIs for processing object configuration libvirt-gconfig.x86_64: W: no-documentation libvirt-gconfig-devel.x86_64: W: summary-not-capitalized C libvirt object APIs for processing object configuration development files libvirt-glib.src: W: summary-not-capitalized C libvirt glib integration for events libvirt-glib.x86_64: W: summary-not-capitalized C libvirt glib integration for events libvirt-glib.x86_64: E: incorrect-fsf-address /usr/share/doc/libvirt-glib-0.0.1/COPYING libvirt-glib-devel.x86_64: W: summary-not-capitalized C libvirt glib integration for events development files libvirt-gobject.x86_64: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization libvirt-gobject.x86_64: W: summary-not-capitalized C libvirt object APIs for managing virtualization hosts libvirt-gobject.x86_64: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization libvirt-gobject.x86_64: W: no-documentation libvirt-gobject-devel.x86_64: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization libvirt-gobject-devel.x86_64: W: summary-not-capitalized C libvirt object APIs for managing virtualization hosts development files libvirt-gobject-devel.x86_64: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization 8 packages and 0 specfiles checked; 1 errors, 13 warnings. This all looks fine. Can you toggle the fedora-review=+ flag if you consider this approved now. Sorry for dragging my feet here, there was this turkey thing... anyway, I'll get the formal review completed today package name: ok spec file name: ok packaging guidelines: ok, modulo whats mentioned below license: ok license field: ok license file: ok spec language: ok spec readable: ok upstream sources: ok buildable: ok excludearch: ok buildrequires: ok locale handling: ok ldconfig: ok system libs: ok relocatable: ok dir ownership: ok duplicate files: ok permissions: ok macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok static libs: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok file ownership: ok utf8 filenames: ok New Package SCM Request ======================= Package Name: libvirt-glib Short Description: libvirt integration with GLib / GObject Owners: berrange Branches: f15 f16 InitialCC: Git done (by process-git-requests). Mattias, please take ownership of review BZs. Thanks! Built into rawhide. |