Bug 754459

Summary:	Guided Rule Editor : mixing formula and field constraint in same pattern makes editor crash
Product:	[JBoss] JBoss Enterprise BRMS Platform 5	Reporter:	manstis
Component:	User Interface	Assignee:	manstis
Status:	VERIFIED ---	QA Contact:	Lukáš Petrovický <lpetrovi>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	5.2
Target Milestone:	---
Target Release:	BRMS 5.3.0.GA
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	An unhandled null pointer caused the guided rule editor to crash when a normal field constraint and a formula were added to the same pattern. This issue has been resolved and these circumstances no longer cause the guided rule editor to crash.	Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description manstis 2011-11-16 15:19:14 UTC

Description of problem:

In the guided rule editor (BRL) if you add a normal field constraint and then a formula to the same pattern the editor crashes. There is no work-around.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a new rule
2. Add a condition
3. Then do this in any order:
4. Add a "normal" restriction
5. Add a "formula" restriction  

Actual results:

The editor crashes.

Expected results:

The editor shows both the "normal" and "formula" restrictions

Additional info:
Fix has been made to master.

Comment 1 manstis 2011-11-22 19:36:24 UTC

Back-ported to 5.3.x branch.

Comment 3 lcarlon 2012-06-04 00:10:07 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The guided rule editor would crash when a normal field constraint and a formula were added to the same pattern.

Comment 4 lcarlon 2012-06-04 00:10:58 UTC

Hi Mike,

If you could let me know how this was resolved I'll add the information to the release notes.

Thanks
Lee

Comment 5 manstis 2012-06-05 21:08:16 UTC

Sure Lee. There was an unhandled null pointer check that caused the problem. Formulas do not relate to a specific field so some code that examined the field name when parsing formula was failing. This only occurred if the Pattern contained regular constraints.

Comment 6 lcarlon 2012-06-05 23:57:02 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1 +1 @@
-The guided rule editor would crash when a normal field constraint and a formula were added to the same pattern.+An unhandled null pointer caused the guided rule editor to crash when a normal field constraint and a formula were added to the same pattern. This issue has been resolved and these circumstances no longer cause the guided rule editor to crash.

Comment 7 lcarlon 2012-06-06 00:01:44 UTC

Thanks Mike.