Bug 754487

Summary:	qxl-win-0.1-13 not signed
Product:	Red Hat Enterprise Linux 8	Reporter:	Cameron Meadors <cmeadors>
Component:	spice-qxl-xddm	Assignee:	Alon Levy <alevy>
Status:	CLOSED NOTABUG	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	---	CC:	acathrow, dblechte, iheim, pvine, sgrinber
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-05-03 19:46:05 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Cameron Meadors 2011-11-16 16:37:29 UTC

Description of problem:

I downloaded qxl_w7_x86.zip from the -13 build of qxl-win.  I updated the driver on my win7 32bit guest by pointed devicemanager to the inf file from the zip.  Driver information still says 6.0.0.12 from Oct 5 and it is not signed.

Version-Release number of selected component (if applicable):
qxl-win-0.1-13

How reproducible:
Only tried it on one guest so far

Steps to Reproduce:
1. Download zip
2. Update driver from device manager
3. reboot
  
Actual results:
driver installed is unsigned

Expected results:
driver installed is signed

Additional info:

Comment 1 Alon Levy 2011-11-17 14:17:39 UTC

I'm not sure what the problem is:
 the version is 6.0.0.12 - that's correct. The qxl-win-0.1-12 is the unsigned driver, signed by a redhat certificate:

 -rwxr-xr-x. 1 alon alon 6833 Nov  7 10:31 qxl-win-0.1-12/w7/x86/qxl.cat

while qxl-win-0.1-13 contains the new cat file, that's the only difference between the two packages. The cat file contains the signatures, not the executables (qxl.sys and qxldd.dll):

 -rw-r--r--. 1 alon alon 7913 Nov 10 12:37 qxl-win-0.1-13/w7/x86/qxl.cat

Right clicking the cat file in qxl-win-0.1-13 shows it is signed by a Microsoft certificate. Haven't yet installed it, it requires removing the current 0.1-12 driver, since they are the same (and so no upgrade).

Alon

Comment 2 Cameron Meadors 2011-11-17 15:22:58 UTC

Tried win7 64 bit with qxl_w7_x64.zip with the same results: driver is not signed.

Comment 3 Alon Levy 2011-11-17 16:10:15 UTC

(In reply to comment #2)
> Tried win7 64 bit with qxl_w7_x64.zip with the same results: driver is not
> signed.

I can reproduce. I really have no idea yet how the cat file is related exactly, I'm trying to figure this out. Will update.

Alon

Comment 4 Alon Levy 2011-11-17 17:06:39 UTC

my bad, I've messed the line endings of the inf file - I'll build a new package.

Alon

Comment 5 Alon Levy 2011-11-17 18:38:11 UTC

Tracked this to a git setting in brew builds - autocrlf and safecrlf are on.

The end result was that the line endings of the inf file were changed:

qxl-win/brew/qxl-win-0.1-13/w7/x86/qxl.inf: ASCII English text, with CRLF line terminators

But the original, and signed in the cat file, so must not be changed one, is:

signed_win_drivers_6/qxl/w7/x86/qxl.inf: ASCII English text

So a brew RFE is being created which this bug will depend on, but meanwhile you can take the zip files in qxl-win-0.1-13 and add the inf file from qxl-win-0.1-12, and it will install without warnings.

Alon

Comment 6 Alon Levy 2011-11-23 13:45:53 UTC

Hi Cameron,

 did a new build using dos2unix, brew still broken - can you test, it's called qxl-win-0.1-14 (surprise :)

Alon
p.s. the way the bug title is set I can't possibly fix this ever - but I assume that's not what you want, just a whql signed version of qxl-win-0.1-12, which qxl-win-0.1-14 is.