Bug 754525

Summary: Crash when trying to browse samba printers
Product: [Fedora] Fedora Reporter: Roy <nouveau>
Component: sambaAssignee: Guenther Deschner <gdeschner>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 16CC: asn, chrissharp09, christoferbertonha, cir.vfi, claudiomar.costa, fpcc3753, gdeschner, jean, john.mellor, jpopelka, miltondp, peter, raizdepi, raoul, ssorce, tklingenberg, twaugh, ylavi
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard:
Fixed In Version: samba-3.6.1-77.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-21 17:11:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Debug output of system-config-printer
none
Debug output of system-config-printer - 2
none
GDB output of system-config-printer
none
samba-debug-crash.patch
none
File: backtrace none

Description Roy 2011-11-16 18:10:56 UTC
Description of problem:
System-config-printer crashes when trying to add a samba printer.

Version-Release number of selected component (if applicable):
system-config-printer-1.3.7-2.fc16.i686

How reproducible:
Try to add a samba printer by browsing the network

Steps to Reproduce:
1. Start system-config-printer
2. Press the "add" button and enter password several times
3. In "Network Printer" Select Windows printer through Samba
4. Press the "browse" button, maybe twice
  
Actual results:
System-config-printer disappears

Expected results:
The process continues by asking me what kind of a printer it is

Additional info:
system-config-p[1764]: segfault at 0 ip 0106818f sp bfbf78f0 error 4 in libsmbclient.so.0[ff3000+5c9000]

Comment 1 Jiri Popelka 2011-11-16 19:00:01 UTC
Run it from command line as 'system-config-printer --debug' and post the output here as an attachment/comment. Thanks

Comment 2 Roy 2011-11-17 08:41:30 UTC
Created attachment 534161 [details]
Debug output of system-config-printer

Attached you will find the output of system-config-printer --debug > sysconfprint-dbg.txt 2> sysconfprint-dbg.txt . The program itself ends with a segfault.

Comment 3 Tim Waugh 2011-11-17 09:11:45 UTC
Unfortunately some of the output has been missed due to the way you used redirection.  Here is the correct way:

system-config-printer --debug >dbg.txt 2>&1

Comment 4 Roy 2011-11-17 09:44:57 UTC
Created attachment 534168 [details]
Debug output of system-config-printer - 2

Attempt two

Comment 5 Tim Waugh 2011-11-17 10:23:06 UTC
All looks normal.  Could you please run this command?:

su -c 'yum --enablerepo=updates-debuginfo install samba-debuginfo'

Then run system-config-printer under the debugger:

$ gdb --args /usr/bin/python /usr/share/system-config-printer/system-config-printer.py
[...]
(gdb) run

When it crashes, type these commands into gdb:

info locals
bt
quit

Then please paste the output as a comment in this bug report.  Thanks.

Comment 6 Roy 2011-11-17 12:45:38 UTC
Created attachment 534185 [details]
GDB output of system-config-printer

Attached the GDB backtrace (and... well, some noise around it).

Comment 7 Tim Waugh 2011-11-17 13:01:33 UTC
Thanks.  Can you try it again, but instead of 'info locals' etc, type in these commands?:

p debug_num_classes
p classname_table
p classname_table[0]

Seems like a libsmbclient problem.

Comment 8 Roy 2011-11-18 11:35:45 UTC
The output is like following:

GNU gdb (GDB) Fedora (7.3.50.20110722-9.fc16)
--- cut ---
(gdb) p debug_num_classes
$1 = 19
(gdb) p classname_table
$2 = (char **) 0x0
(gdb) p classname_table[0]
Cannot access memory at address 0x0

Comment 9 Tim Waugh 2011-11-18 12:10:13 UTC
*** Bug 754763 has been marked as a duplicate of this bug. ***

Comment 10 Tim Waugh 2011-11-18 12:46:34 UTC
Created attachment 534385 [details]
samba-debug-crash.patch

This fixes it for me.

Comment 11 Andreas Schneider 2011-11-18 14:36:56 UTC
I've reported this upstream to get it fixed for 3.6.2. I will create packages for F16 next week. Thanks for debugging this!

Comment 12 Jiri Popelka 2011-11-21 11:38:57 UTC
*** Bug 755517 has been marked as a duplicate of this bug. ***

Comment 13 Caio Cezar Zapater de Souza 2011-11-21 15:47:46 UTC
Package: system-config-printer-1.3.7-2.fc16
Architecture: x86_64
OS Release: Fedora release 16 (Verne)

Comment
-----
Editing the samba printer

Comment 14 jdnog 2011-11-21 17:51:43 UTC
Package: system-config-printer-1.3.7-2.fc16
Architecture: x86_64
OS Release: Fedora release 16 (Verne)

Comment
-----
Fermeture au cours de la validation de l'imprimante réseau.

Comment 15 Tim Waugh 2011-11-28 11:17:25 UTC
*** Bug 757461 has been marked as a duplicate of this bug. ***

Comment 16 Jiri Popelka 2011-11-30 15:44:06 UTC
*** Bug 758722 has been marked as a duplicate of this bug. ***

Comment 17 Tom Klingenberg 2011-12-04 23:57:12 UTC
Package: system-config-printer-1.3.7-2.fc16
Architecture: x86_64
OS Release: Fedora release 16 (Verne)

Comment
-----
1. Applications -> Other -> Printing
2. [add] button
3. enter root password
4. network printer
5. entered ip address to search, pressed button to initiate action

crash.

Comment 18 Christofer Bertonha 2011-12-07 16:31:27 UTC
Package: system-config-printer-1.3.7-2.fc16
Architecture: x86_64
OS Release: Fedora release 16 (Verne)

Comment
-----
put a Windows 7 ip to find a printer

Comment 19 Jiri Popelka 2011-12-12 10:00:39 UTC
*** Bug 766230 has been marked as a duplicate of this bug. ***

Comment 20 Jiri Popelka 2011-12-13 08:26:08 UTC
*** Bug 767039 has been marked as a duplicate of this bug. ***

Comment 21 Tim Waugh 2011-12-13 09:36:56 UTC
Any chance we could get an updated package for this?

Comment 22 Fedora Update System 2011-12-13 10:43:22 UTC
samba-3.6.1-77.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/samba-3.6.1-77.fc16

Comment 23 Fedora Update System 2011-12-13 21:57:53 UTC
Package samba-3.6.1-77.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing samba-3.6.1-77.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2011-17083/samba-3.6.1-77.fc16
then log in and leave karma (feedback).

Comment 24 Jiri Popelka 2011-12-15 09:06:43 UTC
*** Bug 767791 has been marked as a duplicate of this bug. ***

Comment 25 cir.vfi 2011-12-15 16:20:53 UTC
samba-3.6.1-77 applied and still segfaults when attempting to expand domains found in browse printer dialogue box.

GDB reports:
  Program	received signal	SIGSEGV, Segmentation fault.
  debug_lookup_classname_int (classname=0x34e3c9e2e0 "all") at ../lib/util/debug.c:243


classname_table is still NULL at this point.


$ rpm -qa samba\*
samba-client-3.6.1-77.fc16.x86_64
samba4-libs-4.0.0-37.alpha16.fc16.x86_64
samba-debuginfo-3.6.1-75.fc16.x86_64
samba-winbind-clients-3.6.1-75.fc16.x86_64
samba-3.6.1-77.fc16.x86_64
samba-swat-3.6.1-77.fc16.x86_64
samba-common-3.6.1-77.fc16.x86_64

Comment 26 Raoul Millais 2011-12-20 17:32:25 UTC
Select "Find Network Printer" in devices tree and enter fully qualified host in the Host textbox.  (windows domain).  Click Find.  Crash

rating: 4
Package: system-config-printer-1.3.7-2.fc16
Architecture: x86_64
OS Release: Fedora release 16 (Verne)

Comment 27 Raoul Millais 2011-12-20 17:32:30 UTC
Created attachment 548903 [details]
File: backtrace

Comment 28 Tim Waugh 2011-12-20 17:40:13 UTC
Raoul: what does 'rpm -q libsmbclient' say?

Comment 29 Raoul Millais 2011-12-21 10:10:20 UTC
Hi Tim,

`rpm -q libsmbclient` gives me:

  libsmbclient-3.6.1-75.fc16.x86_64

Comment 30 Tim Waugh 2011-12-21 11:09:55 UTC
OK.  Please try the test update (see comment #23, above).

Comment 31 Raoul Millais 2011-12-21 12:06:55 UTC
Sorry, I only just spotted that after I commented: ABRT submitted the report for me.  I'll give that a test and let you know if there are any more issues.

Thanks for your help.

Comment 32 Fedora Update System 2011-12-21 17:11:22 UTC
samba-3.6.1-77.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.