Bug 754842

Summary: /etc/grub.d/01_users mangles passwords
Product: [Fedora] Fedora Reporter: Jason Tibbitts <j>
Component: anacondaAssignee: Peter Jones <pjones>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: igeorgex, imc, jonathan, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-02-13 21:12:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Jason Tibbitts 2011-11-17 21:22:59 UTC
Description of problem:
/etc/grub.d/01_users does not take care to disable shell variable expansion when printing its data, so the line

    password_pbkdf2 root $1$XXXXX/$XXXXXXXXXXXXXXX/

gets mangled to:

    password_pbkdf2 root //

in the resulting config file.  (Sorry if my password mangling confuses things.)

Trivial just to stick single quotes around the EOF.

Version-Release number of selected component (if applicable):
grub2-1.99-12.fc16.x86_64 and whatever is on the F16 install images.

How reproducible:
I guess every installation that sets a grub password will show this.

I was reporting this against grub2 but it appears that file doesn't come from grub2 or any package installed on the system.  I'm guessing anaconda generates it; my apologies if that guess is wrong.

Comment 1 Jason Tibbitts 2011-11-22 19:37:30 UTC
So it appears that the kickstart option bootloader --md5pass doesn't really work as it used to, the old crypted format doesn't work in grub2, and the pbkdf2 hashes _probably_ won't contain dollar signs.  So perhaps this isn't really an issue, though I'm not sure it would be safe to assume that a dollar sign will never show up there legitimately.

Comment 2 Ian Collier 2012-08-29 17:18:52 UTC
The confusing thing here is that if you infer from the documentation that you should use the --md5pass option with an MD5 password then anaconda may fail to install a valid grub2.cfg file (because grub2-mkconfig outputs a syntax error and leaves the file named grub2.cfg.new) and thus your newly installed system won't boot.

Comment 3 Fedora End Of Life 2013-01-16 16:58:18 UTC
This message is a reminder that Fedora 16 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 16. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '16'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 16's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 16 is end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" and open it against that version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 4 Fedora End Of Life 2013-02-13 21:12:41 UTC
Fedora 16 changed to end-of-life (EOL) status on 2013-02-12. Fedora 16 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.