Bug 754879
| Summary: | Review Request: kup - Kernel.org Uploader | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Konstantin Ryabitsev <icon> |
| Component: | Package Review | Assignee: | Josh Boyer <jwboyer> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | hpa, icon, notting, package-review |
| Target Milestone: | --- | Flags: | jwboyer:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kup-0.3.1-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-10 19:34:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Konstantin Ryabitsev
2011-11-18 02:17:52 UTC
- Package meets naming and packaging guidelines - Spec file matches base package name. - Spec has consistant macro usage. - Meets Packaging Guidelines. - License - License field in spec matches - License file included in package - Spec in American English - Spec is legible. - Sources match upstream md5sum: Upstream doesn't release tarballs, but the git checkout of kup-0.3 matches - BuildRequires correct - Package has %defattr and permissions on files is good. - Package has a correct %clean section. - Package is code or permissible content. - Packages %doc files don't affect runtime. - Package compiles and builds on at least one arch. - Package has no duplicate files in %files. - Package doesn't own any directories other packages own. - Package owns all the directories it creates. - No rpmlint output. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-0.3-1.fc16.noarch.rpm kup.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-server-0.3-1.fc16.noarch.rpm kup-server.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup-server.noarch: W: non-ghost-in-var-run /var/run/kup kup-server.noarch: E: non-standard-dir-perm /var/lib/kup/tmp 01777L kup-server.noarch: W: non-ghost-in-var-run /var/run/kup/lock kup-server.noarch: E: zero-length /var/run/kup/lock kup-server.noarch: W: no-manual-page-for-binary kup-server 1 packages and 0 specfiles checked; 2 errors, 4 warnings. [jwboyer@zod kup]$ rpmlint ~/rpmbuild/RPMS/noarch/kup-server-utils-0.3-1.fc16.noarch.rpm kup-server-utils.noarch: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup-server-utils.noarch: W: no-documentation kup-server-utils.noarch: W: no-manual-page-for-binary gpg-sign-all kup-server-utils.noarch: W: no-manual-page-for-binary genrings 1 packages and 0 specfiles checked; 0 errors, 4 warnings. [jwboyer@zod kup]$ rpmlint kup-0.3-1.fc16.src.rpm kup.src: W: spelling-error %description -l en_US cryptographically -> photographically, typographically, topographically kup.src: W: invalid-url Source0: kup-0.3.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. [jwboyer@zod kup]$ The warnings can be ignored, but the errors might need to be fixed. You should probably add a: Requires: gnupg2 as well. Otherwise gpg-sign-all and genrings aren't going to work very well. Other than that, it looks good. Requires: gnupg ... this doesn't use gnupg2. (In reply to comment #2) > Requires: gnupg ... this doesn't use gnupg2. Ah, yes. Of course you are correct. rpmlint errors can be ignored, since there is a hard requirement for kup-server to have its own 1777 tmp directory (must be on the same FS as the pub directory), and /var/run/kup/lock must be a file that exists in order to flock(), but doesn't need to contain any content. I've added both gnupg and xz to the Requires: for kup-server and kup-server-utils requires kup-server, so the reqs will be in place if someone tries to use genrings or gpg-sign-all. Spec URL: http://fedorapeople.org/~icon/f/kup.spec SRPM URL: http://fedorapeople.org/~icon/f/kup-0.3-2.fc16.src.rpm There is a choice on between a 1777 tmp directory and a tmp directory with individual per-user subdirectories. Those would have to be created by an administrator or an external mechanism. Thanks for the quick fixup. APPROVED. Thanks, jwb! New Package SCM Request ======================= Package Name: kup Short Description: Kernel.org Uploader Owners: icon Branches: f15 f16 el5 el6 InitialCC: Git done (by process-git-requests). kup-0.3-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kup-0.3-2.fc15 kup-0.3-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kup-0.3-2.fc16 kup-0.3-2.fc16 has been pushed to the Fedora 16 testing repository. kup-0.3.1-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/kup-0.3.1-1.el5 kup-0.3.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/kup-0.3.1-1.el6 kup-0.3.1-1.fc15 has been pushed to the Fedora 15 stable repository. kup-0.3.1-1.fc16 has been pushed to the Fedora 16 stable repository. kup-0.3.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. kup-0.3.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |