Bug 754892
| Summary: | Review Request: perl-DBIx-Array - This module is a wrapper around DBI with array interfaces | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | mrdvt92 <davis> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | notting, package-review, t.h.amundsen |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-06-15 21:17:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449, 759698 | ||
|
Description
mrdvt92
2011-11-18 05:07:54 UTC
Hello Mike, Spec file looks good, rpmlint is silent on both spec file and SRPM. One question though: Requires: perl(DBI) Doesn't rpmbuild find this dependency? If it does, this Requires is redundant and should be removed. $ rpm -q --requires perl-DBIx-Array perl(:MODULE_COMPAT_5.14.1) perl(DBI) perl(DBI) perl(base) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 I guess it is found. I don't understand why it matters but if that's what you need I'll drop it. I also fix three misspellings and will have the new version 0.23 on CPAN as soon as I burn it in. Updated URLs for version 0.23 Spec URL: http://linux.davisnetworks.com/yumrepo/fc/16/SPEC/perl-DBIx-Array.spec SRPM URL: http://linux.davisnetworks.com/yumrepo/fc/16/SRPMS/perl-DBIx-Array-0.23-1.fc16.src.rpm hard coded perl(DBI) removed $ rpm -q --requires perl-DBIx-Array perl(:MODULE_COMPAT_5.14.2) perl(DBI) perl(base) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 spec - rpmlint is clean srpm - rpmlint is clean Just jumped into a random package review request for a very brief look: > %changelog > * Sun Aug 28 2011 Michael R. Davis (...) 0.22-1 > - See Changes files In the spec %changelog you're supposed to sum up only your changes related to the RPM packaging of the software. For example, mention what changed in the spec file (= the src.rpm): https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs During the review phase, if multiple updates of the src.rpm are needed, you can negotiate with the reviewer that you don't need to sum up every minor change of the spec file. Practising the creation of proper %changelog entries can be helpful training, however. ;) Updated URLs for version 0.23-2 Spec URL: http://linux.davisnetworks.com/yumrepo/fc/16/SPEC/perl-DBIx-Array.spec SRPM URL: http://linux.davisnetworks.com/yumrepo/fc/16/SRPMS/perl-DBIx-Array-0.23-2.fc16.src.rpm %changelog +* Fri Nov 25 2011 Michael R. Davis (mdavis) 0.23-2 +- Updated changelog (#754892) + +* Mon Nov 21 2011 Michael R. Davis (mdavis) 0.23-1 +- Updated for version 0.23 +- Removed hard coded requires for DBI since rpmbuild finds them from sources (#754892) + * Sun Aug 28 2011 Michael R. Davis (mdavis) 0.22-1 -- See Changes files +- Created spec file with cpanspec I really do appreciate the review process. I hope that my next few packages will be correct right out of the gates. It's a learning experience thinking about how this can be run on multiple OSes both from the past and in the future. Thanks, Mike mrdvt92 Closing as requested by submitter in bug 759697. |