Bug 755023

Summary:	edit-livecd is not included in spec file
Product:	[Fedora] Fedora	Reporter:	Mike Burns <mburns>
Component:	livecd-tools	Assignee:	Brian Lane <bcl>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	high
Version:	16	CC:	adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj, mburns, ovirt-maint
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-11-18 18:03:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Mike Burns 2011-11-18 15:20:14 UTC

Description of problem:
edit-livecd is in the upstream source and tarball, but is not packaged in the rpms.  It needs to be included in the spec file.

Version-Release number of selected component (if applicable):
Current F14 and Current F16 versions

How reproducible:
Always

Steps to Reproduce:
1. yum provides *bin/edit-livecd
2.
3.
  
Actual results:
No result found

Expected results:
shipped with livecd-tools

Additional info:

Comment 1 Mike Burns 2011-11-18 15:21:21 UTC

Proposed patch

diff --git a/livecd-tools.spec b/livecd-tools.spec
index dc780df..204aa4d 100644
--- a/livecd-tools.spec
+++ b/livecd-tools.spec
@@ -84,6 +84,7 @@ rm -rf $RPM_BUILD_ROOT
 %{_bindir}/livecd-creator
 %{_bindir}/livecd-iso-to-disk
 %{_bindir}/livecd-iso-to-pxeboot
+%{_bindir}/edit-livecd
 %{_bindir}/image-creator
 %{_bindir}/liveimage-mount
 %{_bindir}/mkbiarch

Comment 2 Mike Burns 2011-11-18 15:25:40 UTC

And Makefile update:


diff --git a/Makefile b/Makefile
index c2617f8..ca9c004 100644
--- a/Makefile
+++ b/Makefile
@@ -26,6 +26,7 @@ install: man
        $(INSTALL_PROGRAM) -D tools/liveimage-mount $(DESTDIR)/usr/bin/liveimage-mount
        $(INSTALL_PROGRAM) -D tools/livecd-iso-to-disk.sh $(DESTDIR)/usr/bin/livecd-iso-to-disk
        $(INSTALL_PROGRAM) -D tools/livecd-iso-to-pxeboot.sh $(DESTDIR)/usr/bin/livecd-iso-to-pxeboot
+       $(INSTALL_PROGRAM) -D tools/edit-livecd $(DESTDIR)/usr/bin/edit-livecd
        $(INSTALL_PROGRAM) -D tools/mkbiarch.py $(DESTDIR)/usr/bin/mkbiarch
        $(INSTALL_DATA) -D AUTHORS $(DESTDIR)/usr/share/doc/livecd-tools-$(VERSION)/AUTHORS
        $(INSTALL_DATA) -D COPYING $(DESTDIR)/usr/share/doc/livecd-tools-$(VERSION)/COPYING

Comment 3 Brian Lane 2011-11-18 17:50:32 UTC

Thanks!