Bug 755073

Summary: Drift: View file contents of "Old File" is garbled for binary files (eg, .wars)
Product: [Other] RHQ Project Reporter: Mike Foley <mfoley>
Component: driftAssignee: John Sanda <jsanda>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: low Docs Contact:
Priority: low    
Version: 4.2CC: jsanda, skondkar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 707225    
Attachments:
Description Flags
view contents of binary file is garbled
none
the link to view contents of a binary file should not exist
none
sample .war file
none
Screenshot none

Description Mike Foley 2011-11-18 18:21:12 UTC 
Description of problem:  Drift:  View file contents of "Old File" is garbled for binary files (eg, .wars)


Version-Release number of selected component (if applicable):
jon 3. branch

How reproducible:
100%

Steps to Reproduce:
1. basic Drift use-case ... folder being watched has a .war file
2. edit the MANIFEST.MF file in the .war
3. view file contents from Drift snapshot
  
Actual results:
contents of .war file appear garbled.  see screenshots.

Expected results:
should not be able to view file contents of "New" or "Old" file ... or the diff.

Additional info:
Comment 1 Mike Foley 2011-11-18 18:21:59 UTC 
Created attachment 534461 [details]
view contents of binary file is garbled
Comment 2 Mike Foley 2011-11-18 18:22:30 UTC 
Created attachment 534462 [details]
the link to view contents of a binary file should not exist
Comment 3 Mike Foley 2011-11-18 18:26:01 UTC 
Created attachment 534463 [details]
sample .war file
Comment 4 John Sanda 2011-11-28 19:12:30 UTC 
Updated logic so that the view link is hidden for binary files.

master commit hash: 99803343b9014aa9399ef2444cc214061bf0bdb9
Comment 5 John Sanda 2011-11-28 20:00:49 UTC 
This fix is not going into the release_jon3.x branch. Moving to ON_QA.
Comment 6 Mike Foley 2011-11-29 17:00:10 UTC 
verified the fix is not in jon 3 branch.

to do:  verify in master.
Comment 7 Sunil Kondkar 2011-12-02 12:50:54 UTC 
Verified in master build#809 (Version: 4.3.0-SNAPSHOT Build Number: 2b26d44)

The link to view contents of a binary file (.war file) does not exist. Please refer the attached screenshot.
Comment 8 Sunil Kondkar 2011-12-02 12:51:24 UTC 
Created attachment 539612 [details]
Screenshot
Comment 9 Sunil Kondkar 2011-12-09 11:50:34 UTC 
Marking as verified.
Comment 10 Mike Foley 2012-02-07 19:31:48 UTC 
changing status of VERIFIED BZs for JON 2.4.2 and JON 3.0 to CLOSED/CURRENTRELEASE
Comment 11 Mike Foley 2012-02-07 19:31:49 UTC 
marking VERIFIED BZs to CLOSED/CURRENTRELEASE