Bug 755135
Summary: | gnome-session spams syslog with DEBUG messages | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Ben Webb <ben> |
Component: | gnome-session | Assignee: | Ray Strode [halfline] <rstrode> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 16 | CC: | brad, dadreggors, daveg, edgar.hoch, hugh, jmccann, marcus.moeller, rstrode, stern, udovdh |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | x86_64 | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-06-15 00:21:58 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ben Webb
2011-11-19 00:17:29 UTC
Yhis affects me as well. And it seems to have been solved already, two years ago: http://web.archiveorange.com/archive/v/iRKxr60MhF8qkzSuXvpT Why the regression in Fedora 16? Same as https://bugzilla.redhat.com/show_bug.cgi?id=759737 ? I see this too. Got no real response nor a workaround. Here's a simple workaround: Create the file: /etc/rsyslog.d/gnome-session-log.conf With contents: :programname,isequal,"gnome-session" ~ That will throw away all messages from gnome-session. If you prefer to save the most recent messages, change the contents to: :programname,isequal,"gnome-session" /var/log/gnome-session.log & ~ Then you'll need to create the file: /etc/logrotate.d/gnome-session.rotate With contents: /var/log/gnome-session.log { missingok notifempty size 200k daily create 0644 root root } QED. Seeing this too, so I took a quick look at the source code. See: http://git.gnome.org/browse/gnome-session/tree/gnome-session/gdm-log.c Commit: 51129099fd2771a3a7a57452c8dfbb2f42c9acfe Line 76 - 86. The routine handles log levels through a case structure but the debug case has a handy little "fix" to circumvent syslog settings when "debugging is enabled". I think the "if" test needs to be removed. If debugging is enabled by the administrator in the application then they should know to handle the messages in syslog. The application should not try to second guess the administrator. Fix? ===%<--- --- gdm-log.c.orig 2012-02-02 18:03:02.329812240 +0000 +++ gdm-log.c 2012-02-02 18:03:21.423853142 +0000 @@ -74,15 +74,8 @@ prefix = "INFO"; break; case G_LOG_LEVEL_DEBUG: - /* if debug was requested then bump this up to ERROR - * to ensure it is seen in a log */ - if (syslog_levels & G_LOG_LEVEL_DEBUG) { - priority = LOG_WARNING; - prefix = "DEBUG(+)"; - } else { - priority = LOG_DEBUG; - prefix = "DEBUG"; - } + priority = LOG_DEBUG; + prefix = "DEBUG"; break; default: priority = LOG_DEBUG; ===%<--- How the syslog_levels debug flag is being set is another matter - I'll try to track that down later. --DaveG. IMO, if G_LOG_LEVEL_DEBUG isn't set then the message shouldn't be logged at all. And it if is set, the message should have LOG_DEBUG priority. Still, you're right. The real problem is that syslog_levels is set wrongly. After looking at the source code for a while (and a few beers) I don't see (from the source code, `cat /proc/###/cmdline`) how debug is being enabled. I MUST be enabled in main(), the only call that sets debug mode in the source: The first syslog message nails that. My F16 is an upgrade from F14 and I'm still sorting through the debris... Question: Is this restricted to upgrades? Nailing the issue is going to require some debug work. The command line from the process does not show any '--debug' options, but are there a GTK option to set this by default? Beyond me. More debug and more beer required... --DaveG. Maybe related I see also Xorg being started with logverbose 7 without reason, does this have the same reason, cause or something? I am running upgraded F16's so I cna't help with that question. The problem occurs for me and I have a freshly installed Fedora 16. I can also confirm this in Fedora 17. This is annoying and makes it hard to actually track down REAL issues because we have to wade through tons of DEBUG messages. Why is there no answer for this yet? We have gone through a whole release and into yet another release and no way to get this spam removed from our logs? This is a duplicate bug, while this report was opened first... bug #759737 has more info and has an external tracker link to the bugzilla.gnome.org but. It may be better to mark this as a duplicate of #759737 While this is not news to Ray Stroder, it may be news for the others here... The upstream patch to fix this issues is in according to the external bug tracker at Gnomes bugzilla: https://bugzilla.gnome.org/show_bug.cgi?id=672801 Sorry, that is Ray Strode (not Stroder). gdm-3.2.1.1-10.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/gdm-3.2.1.1-10.fc16 gdm-3.4.1-3.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/gdm-3.4.1-3.fc17 Thanks Ray! Package gdm-3.4.1-3.fc17: * should fix your issue, * was pushed to the Fedora 17 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing gdm-3.4.1-3.fc17' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2012-9175/gdm-3.4.1-3.fc17 then log in and leave karma (feedback). Works for me, and I left Karma. gdm-3.4.1-3.fc17 has been pushed to the Fedora 17 stable repository. If problems still persist, please make note of it in this bug report. gdm-3.2.1.1-10.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |