Bug 755308

Summary: /usr/include/claws-mail/common/defs.h should not include glibconfig.h
Product: [Fedora] Fedora Reporter: Niels de Vos <ndevos>
Component: claws-mailAssignee: Andreas Bierfert <andreas.bierfert>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: high    
Version: rawhideCC: andreas.bierfert, bugs.michael, tomspur
Target Milestone: ---Keywords: EasyFix, Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-25 02:40:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
fix to include only glib.h none

Description Niels de Vos 2011-11-20 15:39:15 UTC 
Created attachment 534659 [details]
fix to include only glib.h

Description of problem:
claws-mail-plugins can currently not be built as claws-mail provides the broken header file claws-mail/common/defs.h

Version-Release number of selected component (if applicable):
claws-mail in Rawhide

How reproducible:
100%

Steps to Reproduce:
1. fedpkg clone claws-mail-plugins
2. fedpkg build --scratch
  
Actual results:
Building the package fail with:
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/claws-mail/common/defs.h:27,
                 from archiver_prefs.c:24:
/usr/include/glib-2.0/glib/gmacros.h:32:2: error: #error "Only <glib.h> can be included directly."
In file included from /usr/lib64/glib-2.0/include/glibconfig.h:9:0,
                 from /usr/include/claws-mail/common/defs.h:27,
                 from archiver_gtk.c:26:
/usr/include/glib-2.0/glib/gmacros.h:32:2: error: #error "Only <glib.h> can be included directly."


Expected results:
Functional rebuilt of claws-mail-plugins.

Additional info:
The rebuilt of claws-mail-plugins is needed for the new libarchive (.so bump). Only after fixing the claws-mail/common/defs.h, claws-mail-plugins can be rebuilt successfully.

With the attached patch, claws-mail still builds without issues:
- http://koji.fedoraproject.org/koji/taskinfo?taskID=3527447
Comment 1 Michael Schwendt 2011-11-20 16:06:20 UTC 
> the broken header file claws-mail/common/defs.h

It's not broken.  It just requires an update for the breakage introduced by glib 2.31: http://lists.fedoraproject.org/pipermail/devel/2011-October/158746.html
Comment 2 Niels de Vos 2011-11-20 16:52:57 UTC 
> > the broken header file claws-mail/common/defs.h
> 
> It's not broken.  It just requires an update for the breakage introduced by
> glib 2.31:
> http://lists.fedoraproject.org/pipermail/devel/2011-October/158746.html

Correct, it is not broken, it was just missed in the update that makes claws-mail work with the new glib. Thanks for looking into this!
Comment 3 Michael Schwendt 2011-11-25 02:40:22 UTC 
Went ahead and fixed this myself since there have been attempts at rebuilding the -plugins package.