Bug 755542

Summary: when no model selected I can press OK without any response
Product: Red Hat Enterprise Linux 5 Reporter: Vladimir Benes <vbenes>
Component: system-config-displayAssignee: Adam Jackson <ajax>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.8   
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-21 06:47:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 758797    

Description Vladimir Benes 2011-11-21 12:43:32 UTC
Description of problem:
when I run s-c-d, enable dualhead and press OK while no monitor selected, I will get dialog to select monitor. If I cancel and press OK I can see traceback
Traceback (most recent call last):
  File "/usr/share/system-config-display/xConfigDialog.py", line 125, in ok
    self.second_monitor_model, self.second_monitor_vrefresh, self.second_monitor_hsync = self.second_monitor_dialog.dehydrate_second_monitor(self.state)
  File "/usr/share/system-config-display/monitorDialog.py", line 213, in dehydrate_second_monitor
    return model, vsync, hsync
UnboundLocalError: local variable 'model' referenced before assignment

but whatmore when I want to select the monitor now.. I will get another traceback
UnboundLocalError: local variable 'model' referenced before assignment
Traceback (most recent call last):
  File "/usr/share/system-config-display/xConfigDialog.py", line 391, in configure_second_monitor
    self.second_monitor_dialog.goto_path()
  File "/usr/share/system-config-display/monitorDialog.py", line 110, in goto_path
    self.tree_view.expand_row(self.probed_path[:-1], TRUE)
TypeError: could not convert path to a GtkTreePath

should I file another bug for it or can we fix it in this one?

Version-Release number of selected component (if applicable):
system-config-display-1.0.48-2.el5

How reproducible:
100%

Steps to Reproduce:
1.execute s-c-d in terminal
2.enable dual-head
3.click OK
4.click cancel in Monitor dialog
5.click OK
6.click Configure
  
Actual results:
tracebacks

Expected results:
OK should be greyed out unless Monitor selected or after step 5 we should go back to Monitor dialog again and again

Configure should work every time

Additional info:
I propose to fix this in 5.8 as no other s-c-d is planned in the future for rhel5

Comment 1 Adam Jackson 2011-11-21 19:17:52 UTC
Fix in hand, devel ack.

Comment 5 errata-xmlrpc 2012-02-21 06:47:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2012-0285.html