Bug 755913

Summary: stacktrace when firewall not available
Product: [Fedora] Fedora Reporter: Mads Kiilerich <mads>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED WORKSFORME QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 16CC: jpopelka, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-11-30 10:00:52 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Mads Kiilerich 2011-11-22 12:04:03 UTC
File "/usr/share/system-config-printer/newprinter.py", line 1643, in on_firewall_read
    ipp_allowed = f.check_ipp_client_allowed ()
File "/usr/share/system-config-printer/firewall.py", line 114, in check_ipp_client_allowed
    self.ALLOW_IPP_CLIENT]))
File "/usr/share/system-config-printer/firewall.py", line 97, in _check_any_allowed
    (args, filename) = self._get_fw_data ()
TypeError: 'NoneType' object is not iterable

system-config-printer-libs-1.3.7-2.fc16.x86_64

Comment 3 Tim Waugh 2011-11-22 14:37:36 UTC
Is this repeatable?  Can you please try running this command from the command line:

system-config-printer --debug

and pasting the output in here?

Comment 4 Mads Kiilerich 2011-11-22 14:47:25 UTC
[dev@fladmast ~]$ system-config-printer --debug
+<NewPrinterGUI object at 0x2591500 (newprinter+NewPrinterGUI at 0x264a820)>
Connected as user dev
+<PrinterPropertiesDialog object at 0x259ba50 (printerproperties+PrinterPropertiesDialog at 0x2718e20)>
<authconn.Connection instance at 0x258d9e0>: Operation += 'obtaining queue details'
Authentication pass: 1
Authentication: password callback set
Authentication pass: 1
Authentication: password callback set
Authentication pass: 1
Authentication: password callback set
<authconn.Connection instance at 0x258d9e0>: Operation ended
+<ppdcache.PPDCache instance at 0x25a1a70>
refresh
Created subscription 5, events=['printer-added', 'printer-deleted', 'printer-state-changed']
Next notifications fetch in 1s
update_jobs
get_notifications
update_jobs
Next notifications fetch in 60s
Connected as user dev
Authentication pass: 1
Authentication: password callback set
Authentication pass: 1
Authentication: password callback set
Examining firewall
Firewall data obtained
Caught non-fatal exception.  Traceback:
File "/usr/share/system-config-printer/newprinter.py", line 1643, in on_firewall_read
    ipp_allowed = f.check_ipp_client_allowed ()
File "/usr/share/system-config-printer/firewall.py", line 114, in check_ipp_client_allowed
    self.ALLOW_IPP_CLIENT]))
File "/usr/share/system-config-printer/firewall.py", line 97, in _check_any_allowed
    (args, filename) = self._get_fw_data ()
TypeError: 'NoneType' object is not iterable
Continuing anyway..
Firewall all OK; fetching devices

Comment 5 Tim Waugh 2011-11-28 11:59:04 UTC
Are you able to try the current upstream version of system-config-printer (sorry, 33Mb download)?  You can do it like this:

git clone git://git.fedorahosted.org/git/system-config-printer.git
cd system-config-printer
./bootstrap
./configure
make run

I'd like to see the debugging output from that.

No problem if not -- let me know and I can build a test package for you to try.

Comment 6 Mads Kiilerich 2011-11-29 18:29:12 UTC
I can no longer reproduce this, so I guess this report should be closed as invalid ... unless you want to add some extra safeguards anyway ... which it seems like you already have done.