Bug 756235

Summary:	XML and HTML tags to be checked for completeness
Product:	[Retired] Zanata	Reporter:	Alex Eng <aeng>
Component:	Usability	Assignee:	Alex Eng <aeng>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ding-Yi Chen <dchen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	1.4	CC:	damason, sflaniga, zanata-bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-23 04:33:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	756230

Description Alex Eng 2011-11-23 01:12:56 UTC

As a translator I want the XML and HTML tags to be checked for completeness so that I do not face any errors which compiling documents with files containing these tags.


This is a common error that is faced by translators if they are translating long strings with multiple tags.

* Validation Checks are only Warnings (Advisory)
* How to display the error messages - simple validation checks. 

The users would be give an option to enable/disable the test via a checkbok somewhere within the top part of the editor screen.
The warning for any incomplete tag can be displayed in a collapsable tab (similar to the one with the list of users)

Comment 1 Alex Eng 2011-12-18 22:03:47 UTC

Implemented. See https://github.com/zanata/zanata/commit/c16906005ad0c1f4c5d5587d3595e1c7f2dde133

Comment 2 David Mason 2012-01-06 02:22:10 UTC

The following validations are not present, but would be very useful in preventing broken XML or HTML:
 - validation does not check for added tags
 - validation does not check whether the order of tags is different

Translators may need to add tags and change the order of tags, in these cases it would be more useful to show a warning and let the translator ignore it as they know the change was made on purpose, rather than have no warning when a change is accidentally made.


The following are different from the above description, but seem reasonable: 
 - enable/disable checkbox is on the lower right (above comment specifies top).
 - tab is collapsible, but does not stay collapsed for long if there are warnings to display.

Comment 3 Alex Eng 2012-01-06 06:15:55 UTC

Implemented fix. See https://github.com/zanata/zanata/commit/8c5e2aee6e66704623c9a1dc18701786d600ff58

Comment 4 David Mason 2012-01-19 07:38:23 UTC

 - updated to use localisable message strings
 - updated tag order algorithm to detect single moved tag


See:
https://github.com/zanata/zanata/commit/f8eaaa0666357c6fe284d6cf4618650ec3513fc0
https://github.com/zanata/zanata/compare/e69ee68374a74eac8535980bc7dd833ba7795b83...030653ed8063238147f95b7219d0838f75150194

Comment 5 David Mason 2012-01-24 06:16:21 UTC

UI updates, see:
https://github.com/zanata/zanata/compare/030653ed8063238147f95b7219d0838f75150194...d24ee4588f41cc49290f17ec2aef518266d7edbb