Bug 756435
Summary: | Review Request: pytorctl - Python bindings for controlling the Tor router | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Juan Orti <jorti> |
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jorti, notting, package-review, tcallawa, tchollingsworth |
Target Milestone: | --- | Flags: | tcallawa:
fedora-review+
gwync: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | pytorctl-0-0.9.20111213git.fc15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2012-04-25 05:02:02 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 756445 |
Description
Juan Orti
2011-11-23 15:15:53 UTC
I have made some changes, the new files are: Spec URL: https://raw.github.com/jorti/pytorctl-fedora-package/v0-0.7.20111213git/SPECS/pytorctl.spec SRPM URL: https://github.com/jorti/pytorctl-fedora-package/raw/v0-0.7.20111213git/SRPMS/pytorctl-0-0.7.20111213git.fc16.src.rpm The only warning of rpmlint is because the source is fetched from git. $ rpmlint SPECS/pytorctl.spec RPMS/noarch/pytorctl-0-0.7.20111213git.fc16.noarch.rpm SRPMS/pytorctl-0-0.7.20111213git.fc16.src.rpm SPECS/pytorctl.spec: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz pytorctl.src: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz 2 packages and 1 specfiles checked; 0 errors, 2 warnings. Why do you prevent RHEL5 from building this as noarch? RHEL 5 handles noarch packages just fine. (It's noarch *subpackages* of arch-dependent packages that are an issue.) Please use "cp -p" to retain timestamp information from upstream. Also, consider doing something like "install -pm0755" to avoid having to chmod everything post-copy. (It's not necessary, but simpler.) Finally, you don't need the definition for %{?python_sitearch} at the top, since this package isn't arch-specific. (In reply to comment #2) Thank you for your suggestions, I have updated the files: Spec URL: https://raw.github.com/jorti/pytorctl-fedora-package/v0-0.8.20111213git/SPECS/pytorctl.spec SRPM URL: https://github.com/jorti/pytorctl-fedora-package/raw/v0-0.8.20111213git/SRPMS/pytorctl-0-0.8.20111213git.fc16.src.rpm > Why do you prevent RHEL5 from building this as noarch? RHEL 5 handles noarch > packages just fine. (It's noarch *subpackages* of arch-dependent packages that > are an issue.) Ok, I got it wrong, now it's fixed. > Please use "cp -p" to retain timestamp information from upstream. > > Also, consider doing something like "install -pm0755" to avoid having to chmod > everything post-copy. (It's not necessary, but simpler.) I applied those permissions because rpmlint was giving errors. I have fixed this by installing the files without execution and removing the python shebang from the files as seen here: http://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries Updated files SPEC: https://raw.github.com/jorti/pytorctl-fedora-package/v0-0.9.20111213git/SPECS/pytorctl.spec SRPM: https://github.com/jorti/pytorctl-fedora-package/raw/v0-0.9.20111213git/SRPMS/pytorctl-0-0.9.20111213git.fc16.src.rpm Rpmlint output: pytorctl.src: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz SPECS/pytorctl.spec: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz 2 packages and 1 specfiles checked; 0 errors, 2 warnings. = Review = Good: - rpmlint checks return: pytorctl.src: W: invalid-url Source0: pytorctl-0-20111213git.tar.gz 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Safe to ignore, process for generating source documented in spec file. - package meets naming guidelines - package meets packaging guidelines - license (BSD) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (cannot do tarball match, but git sync checks out) - package compiles on f17 (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED, pending resolution of 738556 for sponsorship. New Package SCM Request ======================= Package Name: pytorctl Short Description: Python bindings for controlling the Tor router Owners: jorti Branches: f15 f16 f17 InitialCC: Git done (by process-git-requests). pytorctl-0-0.9.20111213git.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/pytorctl-0-0.9.20111213git.fc17 pytorctl-0-0.9.20111213git.fc17 has been pushed to the Fedora 17 testing repository. pytorctl-0-0.9.20111213git.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/pytorctl-0-0.9.20111213git.fc16 pytorctl-0-0.9.20111213git.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/pytorctl-0-0.9.20111213git.fc15 pytorctl-0-0.9.20111213git.fc17 has been pushed to the Fedora 17 stable repository. pytorctl-0-0.9.20111213git.fc16 has been pushed to the Fedora 16 stable repository. pytorctl-0-0.9.20111213git.fc15 has been pushed to the Fedora 15 stable repository. |