Bug 756776

Summary: Review Request: mingw-libosinfo - MinGW Windows libvirt virtualization library
Product: [Fedora] Fedora Reporter: Daniel Berrangé <berrange>
Component: Package ReviewAssignee: Erik van Pienbroek <erik-fedora>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: erik-fedora, fedora-mingw, notting, package-review
Target Milestone: ---Flags: erik-fedora: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-09-23 05:05:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Erik van Pienbroek 2011-11-30 21:49:04 UTC
Taking for review.

The comments I already mentioned in your mingw32-libvirt-glib review request (bug 754437) also apply for this package. Please resolve these first and after you've published a revised spec file I'll continue with the review

Comment 2 Erik van Pienbroek 2012-06-15 15:36:25 UTC
Daniel: Do you still want to continue this package review?
If so, please update the package so it will be based on the new MinGW Packaging Guidelines which are active as of Fedora 17: https://fedoraproject.org/wiki/Packaging:MinGW

Comment 3 Daniel Berrangé 2012-06-15 15:38:59 UTC
Yes, I do. I was ignoring it until the Mingw32 -> Mingw64 migration in Fedora had settled down. I'll rewrite the specfile to follow new standards soon

Comment 5 Erik van Pienbroek 2012-06-21 20:54:20 UTC
Okay, let's go:
- The BuildRoot tag is not needed any more with modern RPM, so it can be removed
- The Requires: pkgconfig is currently mentioned in the global section (the mingw-libosinfo). However, as no mingw-libosinfo binary rpm is generated, this Requires flag doesn't have any effect. You might want to move it to the %package sections for the mingw32-libosinfo and mingw64-libosinfo packages
- The quotes which you used in the %mingw_make_install "DESTDIR=$RPM_BUILD_ROOT" aren't needed any more and can be removed
- The %defattr tags in the %files sections is also unneeded with modern RPM

Comment 7 Erik van Pienbroek 2012-08-26 18:30:13 UTC
$ rpmlint mingw-libosinfo.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint mingw-libosinfo-0.1.2-2.fc17.src.rpm 
mingw-libosinfo.src: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization
mingw-libosinfo.src: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization
mingw-libosinfo.src: W: spelling-error %description -l en_US hypervisor -> hyper visor, hyper-visor, supervisory
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$ rpmlint mingw32-libosinfo-0.1.2-2.fc17.noarch.rpm mingw64-libosinfo-0.1.2-2.fc17.noarch.rpm 
mingw32-libosinfo.noarch: W: manpage-not-compressed gz /usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-detect.1
mingw32-libosinfo.noarch: W: manpage-not-compressed gz /usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-query.1
mingw32-libosinfo.noarch: W: manpage-not-compressed gz /usr/i686-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-db-validate.1
mingw32-libosinfo.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization
mingw32-libosinfo.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization
mingw32-libosinfo.noarch: W: spelling-error %description -l en_US hypervisor -> hyper visor, hyper-visor, supervisory
mingw64-libosinfo.noarch: W: manpage-not-compressed gz /usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-query.1
mingw64-libosinfo.noarch: W: manpage-not-compressed gz /usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-db-validate.1
mingw64-libosinfo.noarch: W: manpage-not-compressed gz /usr/x86_64-w64-mingw32/sys-root/mingw/share/man/man1/osinfo-detect.1
mingw64-libosinfo.noarch: W: spelling-error Summary(en_US) virtualization -> visualization, actualization, vitalization
mingw64-libosinfo.noarch: W: spelling-error %description -l en_US virtualization -> visualization, actualization, vitalization
mingw64-libosinfo.noarch: W: spelling-error %description -l en_US hypervisor -> hyper visor, hyper-visor, supervisory
2 packages and 0 specfiles checked; 0 errors, 12 warnings.


$ rpm --query --requires mingw32-libosinfo
mingw32(kernel32.dll)  
mingw32(libgio-2.0-0.dll)  
mingw32(libglib-2.0-0.dll)  
mingw32(libgobject-2.0-0.dll)  
mingw32(libosinfo-1.0-0.dll)  
mingw32(libxml2-2.dll)  
mingw32(msvcrt.dll)  
mingw32-crt  
mingw32-filesystem >= 83
pkgconfig  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

$ rpm --query --requires mingw64-libosinfo
mingw64(kernel32.dll)  
mingw64(libgio-2.0-0.dll)  
mingw64(libglib-2.0-0.dll)  
mingw64(libgobject-2.0-0.dll)  
mingw64(libosinfo-1.0-0.dll)  
mingw64(libxml2-2.dll)  
mingw64(msvcrt.dll)  
mingw64-crt  
mingw64-filesystem >= 83
pkgconfig  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1


$ rpm --query --provides mingw32-libosinfo
mingw32(libosinfo-1.0-0.dll)  
mingw32-libosinfo = 0.1.2-2.fc17

$ rpm --query --provides mingw64-libosinfo
mingw64(libosinfo-1.0-0.dll)  
mingw64-libosinfo = 0.1.2-2.fc17


$ wget --quiet https://fedorahosted.org/releases/l/i/libosinfo/libosinfo-0.1.2.tar.gz -O - | md5sum
f4bd25987a1576e7408d3635da6fb342  -
$ md5sum libosinfo-0.1.2.tar.gz 
f4bd25987a1576e7408d3635da6fb342  libosinfo-0.1.2.tar.gz


+ OK
! Needs to be looked into
/ Not applicable

[+] Compliant with generic Fedora Packaging Guidelines
[+] Source package name is prefixed with 'mingw-'
[+] Spec file starts with %{?mingw_package_header}
[+] BuildRequires: mingw32-filesystem >= 95 is in the .spec file
[+] BuildRequires: mingw64-filesystem >= 95 is in the .spec file
[+] Spec file contains %package sections for both mingw32 and mingw64 packages
[+] Binary mingw32 and mingw64 packages are noarch
[+] Spec file contains %{?mingw_debug_package} after the %description section
[+] Uses one of the macros %mingw_configure, %mingw_cmake, or %mingw_cmake_kde4
    to configure the package
[+] Uses the macro %mingw_make to build the package
[+] Uses the macro %mingw_make to install the package
[/] If package contains translations, the %mingw_find_lang macro must be used
[+] No binary package named mingw-$pkgname is generated
[!] Libtool .la files are not bundled
[+] .def files are not bundled
[!] Man pages which duplicate native package are not bundled
[+] Info files which duplicate native package are not bundled
[+] Provides of the binary mingw32 and mingw64 packages are equal
[+] Requires of the binary mingw32 and mingw64 packages are equal


Your package currently also bundles libtool .la files.
These aren't needed any more these days and can be removed.

The man pages are also bundled with the native Fedora libosinfo package.
Because of this they don't need to be bundled with the mingw package.

The remaining rpmlint warnings can be ignored

Please remove the .la files and man pages before importing this package in Fedora


=====================================================
 The package mingw-libosinfo is APPROVED by epienbro
=====================================================

Comment 8 Daniel Berrangé 2012-09-04 13:42:46 UTC
New Package SCM Request
=======================
Package Name: mingw-libosinfo
Short Description: Library for managing OS information for virtualization
Owners: berrange
Branches: f18
InitialCC:

Comment 9 Gwyn Ciesla 2012-09-04 13:50:48 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2012-09-05 11:43:19 UTC
mingw-libosinfo-0.2.0-1.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/mingw-libosinfo-0.2.0-1.fc18

Comment 11 Fedora Update System 2012-09-23 05:05:57 UTC
mingw-libosinfo-0.2.0-1.fc18 has been pushed to the Fedora 18 stable repository.