Bug 757114

Summary: Decision Table Wizard cannot deal with Strings in action columns
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Zuzana Krejčová <zkrejcov>
Component: BRM (Guvnor)Assignee: manstis
Status: VERIFIED --- QA Contact: Lukáš Petrovický <lpetrovi>
Severity: medium Docs Contact:
Priority: unspecified    
Version: BRMS 5.3.0.GACC: lpetrovi, manstis
Target Milestone: ---   
Target Release: BRMS 5.3.0.GA   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
When creating a decision table with the decision table wizard and inserting a new fact, validation fails if the field used is String, because the wizard does not add enclosing quotation marks to the entry. This has been resolved and the wizard now adds quotation marks to values of type String.
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
validation error
none
missing q.marks
none
added column none

Description Zuzana Krejčová 2011-11-25 13:59:10 UTC
Created attachment 536328 [details]
validation error

Description of problem:
As shown in the screenshots, when creating a decision table via the new wizard and inserting a new fact (action column), the validation will fail if the field used is a String. The value of that field isn't enclosed in quotation marks (see screenshot - "missing q.marks").


Version-Release number of selected component (if applicable):
BRMS 5.3.0 dev5


Steps to Reproduce:
1. Create a new rule - guided decision table - using the wizard.
2. Switch to section Add Actions to insert Facts and add a new fact with a text field.
3. Optionally, you can add some csv list or default value.
4. Click Finish.
5. Add row. If you didn't type in a default value, enter some value into the appropriate cell.
6. Validate the DT.

  
Actual results:
Validation results dialogue shows an error, as seen in the screenshot - "validation error".


Expected results:
Dialogue showing successful validation.


Additional info:
This happens only with columns generated by the wizard. Adding the same column after finishing the wizard works right (see screenshot - "added column").

Comment 1 Zuzana Krejčová 2011-11-25 13:59:46 UTC
Created attachment 536329 [details]
missing q.marks

Comment 2 Zuzana Krejčová 2011-11-25 14:00:12 UTC
Created attachment 536330 [details]
added column

Comment 3 Zuzana Krejčová 2011-11-25 14:03:00 UTC
Forgot to mention - the obvious workaround is to manually "correct" all the strings. Where you might have had a list of string1,string2,string3, you put "string1","string2","string3" instead.

Comment 4 Zuzana Krejčová 2011-11-25 15:07:36 UTC
The same happens with action columns for updated facts.

Comment 5 manstis 2011-12-02 17:08:55 UTC
Already fixed on master. Back-ported to 5.3.x branch.

Comment 7 lcarlon 2012-06-04 00:07:40 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
When creating a decision table with the decision table wizard and inserting a new fact, validation fails if the field used is String, because the wizard does not add enclosing quotation marks to the entry. This has been resolved and the wizard now adds quotation marks to values of type String.