Bug 757167

Summary: Decision Table Wizard lets user create an empty binding
Product: [JBoss] JBoss Enterprise BRMS Platform 5 Reporter: Zuzana Krejčová <zkrejcov>
Component: BRM (Guvnor)Assignee: manstis
Status: VERIFIED --- QA Contact: Lukáš Petrovický <lpetrovi>
Severity: medium Docs Contact:
Priority: unspecified    
Version: BRMS 5.3.0.GACC: lpetrovi, manstis
Target Milestone: ---   
Target Release: BRMS 5.3.0.GA   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
The decision table wizard users must specify variable bindings for facts used. The wizard allows user to enter an a single space " " as a binding, which results in a validation error. The decision table wizard has been modified to prevent users entering a single space " " as a binding.
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Zuzana Krejčová 2011-11-25 16:23:31 UTC
Description of problem:
In the wizard, user must specify variable bindings for any fact used. The wizard lets you enter a space as a binding (" ") which results in error, when the user tries to validate the decision table. It is the same behaviour as in BZ 744737 Guided editor: problematic removing of variable binding.
Rows with that fact look in the source like this:
  when  
          : Fact(/*whatever was matched here*/)
  then


Version-Release number of selected component (if applicable):
BRMS 5.3.0 dev5


Steps to Reproduce:
1. Create a new rule - guided decision table - using the wizard.
2. Add a Fact in the next section with a correct binding.
3. Add another Fact, enter a single space as a binding.
4. Next section, add some field constraints to both.
5. Finish and view source of the new decision table or try to validate it.
  

Actual results:
Validation fails and source shows something like
  when  
          : Fact(/*whatever was matched here*/)
  then


Expected results:
Both source and validation should be ok.


Additional info:
Only an issue with the wizard, Web DT (Guided) doesn't allow spaces as binding.

Comment 1 manstis 2011-12-02 16:24:55 UTC
Already fixed on master backported to 5.3.x branch. Also fixed for other "binding" editors (Fact Pattern binding and Field binding on BRL editor).

Comment 3 Zuzana Krejčová 2012-01-31 12:33:46 UTC
Found it again - a space can still be entered as a variable binding in the "add actions to insert facts" section. Again, a fact can be assigned an empty binding this way. Again, results in validation errors.

Comment 4 manstis 2012-01-31 13:02:09 UTC
Sorry, I hadn't merged the change for that page. Done now.

Comment 5 Ryan Zhang 2012-02-15 09:11:32 UTC
Please verify the issue on 5.3 ER4.

Comment 6 lcarlon 2012-06-01 05:36:47 UTC
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The decision table wizard users must specify variable bindings for facts used. The wizard allows user to enter an a single space " " as a binding, which results in a validation error. The decision table wizard has been modified to prevent users entering a single space " " as a binding.