Bug 757299

Summary: 30_os-prober incorrectly calls grub-probe instead of grub2-probe
Product: [Fedora] Fedora Reporter: Chris Murphy <bugzilla>
Component: grub2Assignee: Peter Jones <pjones>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 16CC: awilliam, dennis, pjones
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-08 17:31:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Chris Murphy 2011-11-26 08:08:17 UTC
Description of problem:
30_os-prober incorrectly calls grub-probe instead of grub2-probe

Version-Release number of selected component (if applicable):
Version     : 1.99
Release     : 12.fc16
Architecture: x86_64
From repo   : anaconda-0


How reproducible:
100%

Steps to Reproduce:
1. System with Mac OS X on it  in addition to Fedora 16).
2. grub2-mkconfig -o /boot/grub2/grub.cfg

  
Actual results:
Fails to generate grub.cfg, leaving grub.cfg.new. WITHOUT ERROR.
Inspection of grub.cfg reveals the last line is: ### BEGIN /etc/grub.d/30_os-prober ###

Therefore no grub.d script from 30 and after are run. And a grub.cfg is not created.

*** This bug makes grub2-mkconfig fatal on systems with Mac OS X.***


Expected results:
I expect the script to produce a grub.cfg.


Additional info, regression and solution:

using set -x in 30_os-prober I'm able to locate the point of failure:
Found Mac OS X on /dev/sda2
+ case ${BOOT} in
++ grub-probe --target=fs_uuid --device /dev/sda2
+ OSXUUID=
[root@f16 grub.d]#

In 30_os-prober line 171 is incorrectly calling grub-probe instead of grub2-probe
OSXUUID="`grub-probe --target=fs_uuid --device ${DEVICE} 2> /dev/null`"

If I change grub-probe to ${grub_probe} which translates into grub2-probe presently, then the script now works correctly.

Comment 1 Adam Williamson 2011-12-08 17:31:06 UTC

-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

*** This bug has been marked as a duplicate of bug 737203 ***