Bug 757314

Summary: Review Request: ipgrab - A verbose packet sniffer for hosts
Product: [Fedora] Fedora Reporter: Fabian Affolter <mail>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: notting, volker27
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: NotReady
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-08-15 10:37:29 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Fabian Affolter 2011-11-26 11:49:52 UTC 
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/ipgrab.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/ipgrab-0.9.8-1.fc16.src.rpm

Project URL: http://ipgrab.sourceforge.net/

Description:
This program reads and parses packets from the link layer through the
transport layer, dumping explicit header information along the way.
It is a lot like tcpdump from LBL except that I've made an effort to
dump every relevant header field possible.  The overall structure of
the code is loosely based on tcpdump and I've lifted a few modules
from the tcpdump distribution when necessary, rather than re-inventing
the wheel.  In particular, the address conversion hashing routines are
pretty much lifted verbatim, as well as the TCP options section.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3542804

rpmlint output:
[fab@laptop017 SRPMS]$ rpmlint ipgrab-0.9.8-1.fc16.src.rpm 
ipgrab.src: W: spelling-error %description -l en_US tcpdump -> dumpster
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

[fab@laptop017 x86_64]$ rpmlint ipgrab*
ipgrab.x86_64: W: spelling-error %description -l en_US tcpdump -> dumpster
ipgrab.x86_64: E: incorrect-fsf-address /usr/share/doc/ipgrab-0.9.8/COPYING
ipgrab.x86_64: W: no-manual-page-for-binary ipgrab
ipgrab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ipgrab-0.9.8/src/layers.c
[...]
ipgrab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ipgrab-0.9.8/src/ethertypes.c
ipgrab-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/ipgrab-0.9.8/src/spx.c
2 packages and 0 specfiles checked; 120 errors, 2 warnings.
Comment 1 Volker Fröhlich 2011-12-09 12:55:09 UTC 
Doesn't build on my machine:

gcc -DHAVE_CONFIG_H -I. -I. -I..   -I/usr/include/ucd-snmp -I/usr/include/ucd-snmp -I/usr/include -Wall -Wstrict-prototypes -Wformat -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4  -m64 -mtune=generic -c snmp.c
In file included from snmp.c:43:0:
/usr/include/ucd-snmp/asn1.h:7:2: error: #error "Please update your headers or configure using --enable-ucd-snmp-compatibility"
In file included from snmp.c:47:0:
/usr/include/ucd-snmp/snmp.h:7:2: error: #error "Please update your headers or configure using --enable-ucd-snmp-compatibility"
make[2]: *** [snmp.o] Error 1

I think this is related to having Net-SNMP instead of UCD.

You can drop rm -rf %{buildroot}

Probably re-phrase this passage of the description: "except that I've made an effort". There are also two spaces before the next sentence.
Comment 2 Volker Fröhlich 2012-04-10 21:51:36 UTC 
How's it going here?
Comment 3 Fabian Affolter 2012-08-29 07:46:41 UTC 
So fare I'm still not able to build this package. Additional works is needed.
Comment 4 Fabian Affolter 2013-08-15 10:37:29 UTC 
Upstream is not responsive. It seems that net-snmp is compiled with '--enable-ucd-snmp-compatibility' but ipgrab is not recognizing it.