Bug 757355

Summary: Review Request: telepathy-kde-contact-applet - Plasma applet for managing your Telepathy contacts
Product: [Fedora] Fedora Reporter: Rex Dieter <rdieter>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: alekcejk, kevin, notting, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-03-07 23:05:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 656997    

Comment 1 nucleo 2011-11-26 17:40:28 UTC
"BuildRequires: desktop-file-utils" is not needed because .desktop file installed in %{_kde4_datadir}/kde4/services/.

"%{?_kde4_version:Requires: kdelibs4%{?_isa} >= %{_kde4_version}}" can be added.

And looks like "BuildRequires: telepathy-qt4-devel" missed.

Most of code is LGPLv2+ but config.cpp, config.h, contact-wrapper.cpp, contact-wrapper.h, telepathy-contact.cpp, telepathy-contact.h is GPLv2+ - maybe this is mistake?

Comment 2 Rex Dieter 2011-11-26 18:06:51 UTC
Spec URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-applet.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/telepathy-kde/telepathy-kde-contact-applet-0.2.0-2.fc16.src.rpm

%changelog
* Sat Nov 26 2011 Rex Dieter <rdieter> 0.2.0-2
- BR: +telepathy-qt4-devel, -desktop-file-utils

keeping License: GPLv2+ 
that's the current value for mixing LGPLv2+, GPLv2+ sources

Comment 3 nucleo 2011-11-26 19:31:31 UTC
Is .qml plasmoid form plasmoids/org.kde.telepathy-contact/ should work in KDE 4.7?

Comment 4 Rex Dieter 2011-12-21 20:06:19 UTC
Not sure, yes? :)

Comment 5 nucleo 2012-03-07 23:05:38 UTC

*** This bug has been marked as a duplicate of bug 784950 ***