Bug 75747

Summary:	gnome-session checking naive (or remove entirely)
Product:	[Fedora] Fedora	Reporter:	Need Real Name <vader>
Component:	htmlview	Assignee:	Christopher Aillon <caillon>
Status:	CLOSED CANTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mcepl, wtogami
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	---
Hardware:	i386
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2008-02-08 16:17:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Need Real Name 2002-10-11 20:09:33 UTC

Description of Problem:
2 "enhancement" issues:

1. /usr/bin/htmlview (IMHO) could/should use #!/bin/sh rather than #!/bin/bash
for portability, as it does not appear to depend on 'bash' for any reason.

2. The following line which checks for a gnome-session seems rather crude:
if [ "x`/sbin/pidof gnome-session`" != "x" ]; then

IMHO it would be cleaner, more correct (think of multi-user systems), and more
portable to check for some environment variable which is present under a
gnome-session.

Maybe something like the following:

[ $GNOME_DESKTOP_SESSION_ID ]

(I am not 100% sure that variable is _always_ set under gnome-session, that's
just a possible scenario.)

Version-Release number of selected component (if applicable):
2.0.0-6

Comment 1 Mike A. Harris 2002-10-19 03:56:06 UTC

I just inherited htmlview package.  I'm not sure yet if I've just inherited
package maintenance, or if I've inherited the script as upstream maintainer
yet.

While I'm a fan of portability, I'm not a big fan of the raw bourne
shell, and I freely use bashisms as they make my job easier, and
bash is present on every (supported) Red Hat Linux system.

I'll look into it, but I won't promise anything.

I'll also look into the gnome thing.

Comment 2 Need Real Name 2005-02-22 23:34:02 UTC

Hi Mike or Jonathan,

any updates on this?

$ env | grep GNOME
GNOME_KEYRING_SOCKET=/path/to/socket
GNOME_DESKTOP_SESSION_ID=Default

IMHO checking for some environment variable would be better than
checking for a process.  A gnome-session process could belong to a
different user on a different X session.

Comment 3 Warren Togami 2005-04-25 07:35:19 UTC

Agreed this is naive and wrong.  However it only happens in a dead codepath that
only users without X would hit.  Either that old crap should be removed and
non-X be declared unsupported or this should be fixed in a non-naive way.

Comment 4 Matěj Cepl 2008-02-08 16:17:40 UTC

Since this bugzilla report was filed, we have seriously upgraded Gecko-related
packages in Rawhide, which may have resolved this issue. Users who have
experienced this problem are encouraged to upgrade their system to the latest
version of their distribution available.

Closing this bug as CANTFIX. Please, reopen, if this bug is still reproducable
on the latest update of your distribution.

[This is mass-closing of bugs which seem to be too old and irrelevant anymore;
we are sorry, if we are closing your bug in mistake; please, don't hesitate to
reopen, if it is still alive issue.]