Bug 757866 (kde-printer-applet)

Summary:	Review Request: kde-printer-applet - KDE printer applet
Product:	[Fedora] Fedora	Reporter:	Rex Dieter <rdieter>
Component:	Package Review	Assignee:	Jaroslav Reznik <jreznik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jreznik, kevin, mattia.verga, notting, package-review, robatino
Target Milestone:	---	Flags:	jreznik: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-15 01:38:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	656997, 765955

Description Rex Dieter 2011-11-28 20:48:33 UTC

Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet.spec
SRPM URL: http://rdieter.fedorapeople.org/rpms/kdeutils/printer-applet-4.7.80-1.fc16.src.rpm
Description:
Printer Applet is a system tray utility that shows current print jobs,
shows printer warnings and errors.


NOTES:
This is being split out in kde-4.7.80 from previously monolithic kdeutils
package.

Starting off here with upstream's 'printer-applet' name, but we probably want to use something less generic, perhaps kde-printer-applet.

Comment 1 Rex Dieter 2011-12-08 18:13:14 UTC

Spec URL: http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/kdeutils/kde-printer-applet-4.7.90-1.fc16.src.rpm

update to 4.7.90, renamed to kde-printer-applet

Comment 2 Mattia Verga 2011-12-31 10:50:44 UTC

I think the .desktop file should be renamed to respect the new package name for consistency (from 'printer-applet.desktop' to 'kde-printer-applet.desktop').

Also, the .spec file is missing the desktop-file-validate step.

Comment 3 Kevin Kofler 2011-12-31 16:42:13 UTC

I don't think renaming the .desktop file makes sense.

Comment 4 Rex Dieter 2011-12-31 17:23:26 UTC

I'll advocate renaming stuff away from being generic, but I'd also argue it's not something that should be considered a review blocker.

Comment 5 Rex Dieter 2011-12-31 17:23:50 UTC

make that "being generic... *upstream*"

Comment 6 Kevin Kofler 2011-12-31 18:18:12 UTC

Agreed, renaming things upstream would make a lot of sense, it's renaming the .desktop file downstream which I don't think is helpful.

Comment 7 Jaroslav Reznik 2012-01-13 17:51:00 UTC

+1 to not renaming downstream

Name: ok (make sense to use less generic, upstream it?)
Summary: ok
Version: ok

License: ok
Url: ok
BRs: ok
Reqs: ok
Conflicts/Obsoletes/Provides: ok
Description: ok
Macros used consistently: ok
Docs: ok

Missing desktop-file-validate.

rpmlint kde-printer-applet-4.7.97-1.fc16.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 8 Jaroslav Reznik 2012-01-13 18:02:41 UTC

Sources: ok (md5sum b66e859e551a10e09712217b1d160a95)

For desktop file validation - skip this step, it's autorun desktop file, not shown in Kickstart. I didn't realize it, sorry.

APPROVED

Comment 9 Rex Dieter 2012-01-13 18:05:04 UTC

New Package SCM Request
=======================
Package Name: kde-printer-applet
Short Description: KDE Printer applet
Owners: than jreznik ltinkl rnovacek rdieter kkofler
Branches: f16
InitialCC:

Comment 10 Gwyn Ciesla 2012-01-13 18:35:32 UTC

Git done (by process-git-requests).

Comment 11 Rex Dieter 2012-01-15 01:38:54 UTC

imported.