Bug 758470
| Summary: | Review Request: vmmlib | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jaroslav Škarvada <jskarvad> |
| Component: | Package Review | Assignee: | Jan Kaluža <jkaluza> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | eilemann, jkaluza, notting, package-review |
| Target Milestone: | --- | Flags: | jkaluza:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | vmmlib-1.0-0.2.rc1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-14 14:22:52 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 758472 | ||
|
Description
Jaroslav Škarvada
2011-11-29 21:31:02 UTC
The package looks good to me and I haven't found any issue there. The only thing is that non-working unit-test. I can't say if the test itself is broken or there's really bug in vmmlib. The true is vmmlib throws an exception which can be catched later. But what I would like to see is to at least contact upstream and get its opinion on this. I'm not sure I want to accept library when unit-test fails for unknown reason. Could you ask upstream to clarify the situation please? They look active according to commits, so it should not take a long time to get the response. [YES] rpmplint is silent [YES] Package meets naming guidelines. [YES] Package meets packaging guidelines. [YES] Spec file matches base package name. [YES] License file is present, matching with spec file. [YES] Licensing Guidelines are met. [YES] Spec file is legible and in American English. [YES] Sources match upstream. [YES] Package builds OK. [YES] BuildRequires are correct. [YES] Package doesn't bundle copies of system libraries. [YES] Package owns all the directories it creates. [YES] Package has no duplicity in %files. [YES] Permission on files are set properly. [YES] Package is code or permissible content. [YES] %doc files don't affect runtime. [YES] Package doesn't own files/directories that other packages own. [YES] All files are valid UTF-8. Should items: [YES] Package builds in mock. [YES] Package uses sane scriptlets. [NO] Package contains man pages. [YES] Very simple functionality test passed. Thanks for the review. The problem seems to be caused by wrong initialization of integer variables on 64 bit platforms. The Fortran code uses/initializes 32 bit integers, but the f2c.h defines 64 bit integers, which are later used and compared in the test suite. Problem reported to f2c, bug 767408 and workarounded in vmmlib until correct fix will be available. Also there seems to be some more minor problems in vmmlib testsuite, I will report them upstream later. Spec URL: http://jskarvad.fedorapeople.org/vmmlib.spec SRPM URL: http://jskarvad.fedorapeople.org/vmmlib-0-0.2.20111122svn540.fc16.src.rpm The problem was not in vmmlib templates nor lapack. It is responsibility of the code that uses the vmmlib to define this correctly. Accepting the package now. New Package SCM Request ======================= Package Name: vmmlib Short Description: A vector and matrix math library implemented using C++ templates Owners: jskarvad Branches: f16 InitialCC: jkaluza Git done (by process-git-requests). vmmlib-0-0.2.20111122svn540.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/vmmlib-0-0.2.20111122svn540.fc16 FYI mostly all previously mentioned (minor) problems in unit tests got fixed in the latest version: vmmlib-0-0.3.20111214svn556 Great ;). vmmlib-1.0-0.2.rc1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/vmmlib-1.0-0.2.rc1.fc16 vmmlib-1.0-0.2.rc1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. |