Bug 758488

Summary: F17 live image generation failing after package install with "AttributeError: RPMInstallCallback instance has no attribute 'display'"
Product: [Fedora] Fedora Reporter: Adam Williamson <awilliam>
Component: yumAssignee: Packaging Maintenance Team <packaging-team-maint>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 19CC: adam.stokes, bcl, bruno, dhuff, ffesti, james.antill, Jasper.Hartline, jzeleny, katzj, maxamillion, pmatilai, tla
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 13:59:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Adam Williamson 2011-11-29 22:01:54 UTC
Nightly live image generation is currently failing for all images every day. root.log shows this error right after package installation completes:

DEBUG util.py:247:  Unmounting directory /var/tmp/imgcreate-SgqNfC/install_root
DEBUG util.py:247:  Losetup remove /dev/loop0
DEBUG util.py:247:   
DEBUG util.py:247:  Traceback (most recent call last):
DEBUG util.py:247:    File "/usr/bin/livecd-creator", line 210, in <module>
DEBUG util.py:247:      sys.exit(main())
DEBUG util.py:247:    File "/usr/bin/livecd-creator", line 193, in main
DEBUG util.py:247:      creator.install()
DEBUG util.py:247:    File "/usr/lib/python2.7/site-packages/imgcreate/creator.py", line 642, in install
DEBUG util.py:247:      ayum.runInstall()
DEBUG util.py:247:    File "/usr/lib/python2.7/site-packages/imgcreate/yuminst.py", line 223, in runInstall
DEBUG util.py:247:      ret = self.runTransaction(cb)
DEBUG util.py:247:    File "/usr/lib/python2.7/site-packages/yum/__init__.py", line 1657, in runTransaction
DEBUG util.py:247:      self.verifyTransaction(resultobject, cb.display.event)
DEBUG util.py:247:  AttributeError: RPMInstallCallback instance has no attribute 'display'

See for e.g. http://koji.fedoraproject.org/koji/getfile?taskID=3550440&name=root.log&offset=-4000

Seth says this isn't a problem on the yum side, so it has to be something to do with how python-imgcreate calls it, I guess.

This should be fixed quickly as obviously we really want nightly live images to be generated.

Comment 1 Brian Lane 2011-11-29 22:28:00 UTC
python-imgcreate hasn't changed that code recently. It looks like this:

215         # FIXME: callback should be refactored a little in yum.
216         sys.path.append('/usr/share/yum-cli')
217         import yum.misc
218         yum.misc.setup_locale()
219         import callback
220         cb = callback.RPMInstallCallback()
221         cb.tsInfo = self.tsInfo
222         cb.filelog = False
223         ret = self.runTransaction(cb)
224         print ""
225         self._cleanupRpmdbLocks(self.conf.installroot)
226         return ret

From looking at the callback code, I don't see where the .display attribute is defined. And in yum it has some code that can set it, if a display object gets passed to processTransaction/_doTransaction

So cb.display could be None and yum doesn't check for that condition before accessing cb.display.event

Something must have changed someplace, but it wasn't python-imgcreate. Now, there is certainly a possibility that it needs to be updated for changes in yum, but I'm looking at yum on f15 and it has this same call in it.

Comment 2 Fedora End Of Life 2013-04-03 17:37:30 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 3 Fedora End Of Life 2015-01-09 16:53:30 UTC
This message is a notice that Fedora 19 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 19. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained. Approximately 4 (four) weeks from now this bug will
be closed as EOL if it remains open with a Fedora 'version' of '19'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 19 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Fedora End Of Life 2015-02-17 13:59:14 UTC
Fedora 19 changed to end-of-life (EOL) status on 2015-01-06. Fedora 19 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.