Red Hat Bugzilla – Full Text Bug Listing
|Summary:||Various AS-5 plugin types have unset read-only plugin config props|
|Product:||[Other] RHQ Project||Reporter:||Jay Shaughnessy <jshaughn>|
|Component:||Plugins||Assignee:||Jay Shaughnessy <jshaughn>|
|Status:||CLOSED CURRENTRELEASE||QA Contact:||Mike Foley <mfoley>|
|Target Release:||RHQ 4.3.0|
|Fixed In Version:||4.3||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|:||790075 (view as bug list)||Environment:|
|Last Closed:||2013-09-01 05:58:14 EDT||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
|Bug Depends On:|
|Bug Blocks:||752488, 760116, 790075|
Description Jay Shaughnessy 2011-11-29 17:43:07 EST
Minimally the following types in the AS-5 plugin have plugin config properties that are unset: EAR WAR Embedded WAR This is bad because when you navigate to the plugin config you are immediately in error, the config editor demanding values for the fields which you can not edit. Although not probable, it would make it impossible to actually edit and save the plugin config. The unset properties should be set at discovery or removed from the plugin descriptor. The latter is probably ok since they seem unused.
Comment 1 Jay Shaughnessy 2012-01-16 13:04:28 EST
Each unset property pretty much needs to be reviewed on a case-by-case basis. The offending properties re-occur in several components and are one of: contextPath From what I can see an attempt is made in discovery to set this WAR property. The context path is determined by calling the profile service for "contextRoot". But it either doesn't work at all, or, if the app is stopped, is doc'd to return null. I don't think the property value is actually used anywhere in the plugin code, so not getting set seems to not be a problem, other than in the way described in this BZ. The property could probably be removed but instead I'll just remove the read-only setting. filename From what I can see this property is never set/discovered on any of the several types on which it is declared. Moreover, it seems it is never referenced in the plugin code. As such, I'm removing all occurrences of the property.
Comment 2 Jay Shaughnessy 2012-01-16 13:31:37 EST
Actually, mean to say, set contextPath required="false" in addition to readOnly="false".
Comment 3 Jay Shaughnessy 2012-01-16 14:15:04 EST
master commit 13546f899490b333b4527ce963d1b39b3a097153 required/read-only contextPath and filename props were not being set [reliably] at discovery time. Removed filename props, which did not seem to be used by the plugin. Set contextPath props to required="false". The value does not seem to be used by the plugin but the property is at least defined in the code. Test Notes Import an EAP5 with deployed EAR/War/Embedded WAR and anything else you see fit. In the GUI visit connection settings for one of each type of resource in its hierarchy. Ensure the config editor does not complain when rendering the config.
Comment 4 Heiko W. Rupp 2013-09-01 05:58:14 EDT
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.