Bug 758893

Summary: group Inventory>Members subtab: user should not be able to update the membership of a dynamic group / dynagroup
Product: [Other] RHQ Project Reporter: Ian Springer <ian.springer>
Component: Core UIAssignee: Mike Thompson <mithomps>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: medium    
Version: 4.2CC: ccrouch, hrupp, mithomps
Target Milestone: ---   
Target Release: RHQ 4.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 4.4.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-01 10:19:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 752488, 735475    

Description Ian Springer 2011-11-30 22:15:06 UTC
The Update Membership button should not even be displayed for a dynagroup. We should also make sure our remote API does not allow a user to modify the membership of a dynagroup.

Comment 1 Ian Springer 2011-11-30 22:31:09 UTC
Similarly, on the Resource Inventory>Groups subtab, we should not allow a user to add or remove dynagroups from the list of groups the Resource is a member of. The only way a Resource should be able to get in or out of a dynagroup is via calculation of a group definition expression.

Comment 2 Ian Springer 2011-12-01 19:04:12 UTC
Similarly, on the Inventory>Members subtab for an autogroup, the Update Membership button is shown but is disabled (grayed out). Our convention in the new RHQ GUI is to disable a button if the user does not have authz for the corresponding action, and to not show the button at all if that action would never be applicable even for a superuser. So in this case, rather than disabling the Update Membership button, we should not be showing it at all.

Comment 3 Mike Thompson 2012-03-02 02:07:04 UTC
I removed the Update Membership button for dynagroups and autogroups such they can only be updated via calculation of group definition expression.

Commit: 4553f0365fe298bdcf551fd08f102b855a224ac7

Comment 5 Heiko W. Rupp 2013-09-01 10:19:15 UTC
Bulk closing of items that are on_qa and in old RHQ releases, which are out for a long time and where the issue has not been re-opened since.