| Summary: | kernel-3.1.2-1.fc16 build failure on PPC64, drivers/staging/brcm80211/brcmsmac/ampdu.c | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Karsten Hopp <karsten> |
| Component: | kernel | Assignee: | Josh Boyer <jwboyer> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 16 | CC: | gansalmon, h.reindl, itamar, jonathan, kernel-maint, linville, madhu.chinakonda |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | powerpc | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-3.1.5-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-12-12 21:57:33 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Karsten Hopp
2011-12-01 12:53:49 UTC
So. This is because we supposedly have backported brcm80211 drivers from 3.2-rc2 in brcm80211.patch. Which we obviously do. That backport contains commit:
commit b60987a15628046259be17471fd80ba92cf35ed2
Author: Roland Vossen <rvossen>
Date: Mon Aug 8 15:58:49 2011 +0200
staging: brcm80211: simplified register access macro's in softmac
which should fix the build error.
However, the brcm80211 drivers are still sitting in drivers/staging/ as well in f15/f16. For some reason, those are getting picked up during the ppc build.
Looking in a local x86_64 build, they're also being built there but not installed:
[jwboyer@host brcmsmac]$ pwd
/ssd/jwboyer/kernel/kernel-3.1.fc16/linux-3.1.x86_64/drivers/staging/brcm80211/brcmsmac
[jwboyer@ihatethathostname brcmsmac]$ ls
aiutils.c antsel.h d11.h Makefile phy_shim.h srom.c
aiutils.h antsel.o dma.c modules.order phy_shim.o srom.h
aiutils.o bmac.c dma.h nicpci.c pmu.c srom.o
alloc.c bmac.h dma.o nicpci.h pmu.h stf.c
alloc.h bmac.o mac80211_if.c nicpci.o pmu.o stf.h
alloc.o brcmsmac.o mac80211_if.h otp.c pub.h stf.o
ampdu.c built-in.o mac80211_if.o otp.h rate.c types.h
ampdu.h channel.c main.c otp.o rate.h ucode_loader.c
ampdu.o channel.h main.h phy rate.o ucode_loader.h
antsel.c channel.o main.o phy_shim.c scb.h ucode_loader.o
[jwboyer@host brcmsmac]$
John, unless you say otherwise I'm going to add the removal of the Kconfig and Makefile in drivers/staging/brcm80211/* to brcm80211.patch on f15/f16.
Sure, that seems reasonable -- sorry I didn't think about that! Done and committed to git for f15/f16. kernel-3.1.5-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/kernel-3.1.5-1.fc16 > * Thu Dec 01 2011 Josh Boyer <jwboyer>
> - Apply patch to revert mac80211 scan optimizations (rhbz #731365)
> - Disable the existing brcm80211 staging drivers (rhbz #759109)
does this mean WLAN stops working again with 2.6.41.5-1.fc15?
one of my co-workers was so happy to get his WLAN supported with the last kernel
(In reply to comment #5) > > * Thu Dec 01 2011 Josh Boyer <jwboyer> > > - Apply patch to revert mac80211 scan optimizations (rhbz #731365) > > - Disable the existing brcm80211 staging drivers (rhbz #759109) > > does this mean WLAN stops working again with 2.6.41.5-1.fc15? > one of my co-workers was so happy to get his WLAN supported with the last > kernel No, not at all. There were two separate copies of the brcm80211 drivers in the kernel tree. One existed in the drivers/staging directory and the other is a backport of a newer version of those drivers that live in drivers/net/wireless. We removed the now stale drivers/staging copy of the drivers (really just the build files). The brcm80211 drivers are still built and still included in the kernel. You can see them listed in koji here: http://koji.fedoraproject.org/koji/rpminfo?fileStart=1600&rpmID=2826611&fileOrder=name&buildrootOrder=-id&buildrootStart=0#filelist thank you for your reply! i thought if it goes away i should prepare him sicne he needs WLAn at home and is glad that currently no kmod-packages are needed! BTW: 2.6.41.5-1.fc15 is running smooth on my HP Compaq 8200 Elite CMT PC Package kernel-3.1.5-1.fc16: * should fix your issue, * was pushed to the Fedora 16 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.1.5-1.fc16' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2011-16840/kernel-3.1.5-1.fc16 then log in and leave karma (feedback). kernel-2.6.41.5-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kernel-2.6.41.5-1.fc15 kernel-3.1.5-1.fc16 has been pushed to the Fedora 16 stable repository. If problems still persist, please make note of it in this bug report. kernel-2.6.41.5-4.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kernel-2.6.41.5-4.fc15 kernel-2.6.41.6-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/kernel-2.6.41.6-1.fc15 |